[Libvirt-cim] [PATCH] [TEST] #2 Add new tc to validate that the Disk child pool can be created through the providers

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Mon Apr 27 21:21:38 UTC 2009


Daisy,

Since a lot of the same bugs found in the network pool test case also 
exist here, can you wait until the network pool test case is in the tree 
before submitting an update to this test case?

I think that'll reduce the amount of churn in this patch.

Thanks!

> +from pywbem.cim_types import Uint16
> +
> +cim_errno  = pywbem.CIM_ERR_NOT_SUPPORTED
> +cim_mname  = "CreateChildResourcePool"
> +libvirt_cim_child_pool_rev = 837
> +test_pool = ["dir_pool"]

fs type pools are now supported.

> +
> + at do_main(platform_sup)
> +def main():
> +    options = main.options
> +    rpcs_conn = eval("rpcs_service." + get_typed_class(options.virt, \
> +                      "ResourcePoolConfigurationService"))(options.ip)

Put get_typed_class() on its own line.


> +                status = verify_pool(options.ip, dp, dp_id)
> +                if status != PASS:

The verify_pool() function doesn't verify the attributes of the pool to 
ensure that the pool was created properly.
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list