[Libvirt-cim] [PATCH 1 of 2] Image Creation: add functions for generating a storage volume XML

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Aug 12 16:32:37 UTC 2009


>> +        format = xmlNewChild(target, NULL, BAD_CAST "format", NULL);
>> +        if (format == NULL)
>> +                goto out;
>> +
>> +        if (xmlNewProp(format, BAD_CAST "type", BAD_CAST type) == NULL)
>> +                goto out;
>> +
>> +        /* FIXME:  Need to add permissions and label tags here */
> 
> What about this fixme?
> 

Right now, the StorageVolRASD doesn't have attributes that allow the 
user to set the permissions and flags they want for the image.  This is 
something I'll need to add in the future, but it isn't needed to get the 
initial image creation support working.

Plus, it's a lot of additional code, and I wanted to make the patches 
small enough that they were easy and quick to review.  Once all the 
patches for initial image creation are in the tree, my plan is to do the 
following:

1) Add a method that will allow the user to delete the image
2) Improve the image creation support so that users can specify 
permissions, flags, anything else I've missed/neglected.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list