[Libvirt-cim] [PATCH] [TEST](#2) VirtCIM init for the LXC virt must also receive pae, acpi and apic param
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Tue Dec 8 17:24:37 UTC 2009
Richard Maciel wrote:
> # HG changeset patch
> # User Richard Maciel <rmaciel at linux.vnet.ibm.com>
> # Date 1259986929 7200
> # Node ID 8698f85c7b5fdd68ff4a732852fcb21e5f044497
> # Parent 9445f602d8a8705743254f85ef426d284ab382d4
> [TEST](#2) VirtCIM init for the LXC virt must also receive pae, acpi and apic param
>
> #2:
> - Fixed code style
>
> Signed-off-by: Richard Maciel <rmaciel at linux.vnet.ibm.com>
>
> diff -r 9445f602d8a8 -r 8698f85c7b5f suites/libvirt-cim/lib/XenKvmLib/vxml.py
> --- a/suites/libvirt-cim/lib/XenKvmLib/vxml.py Wed Nov 18 13:50:16 2009 -0800
> +++ b/suites/libvirt-cim/lib/XenKvmLib/vxml.py Sat Dec 05 02:22:09 2009 -0200
> @@ -996,10 +996,13 @@
> address="127.0.0.1", port_num='-1', keymap="en-us",
> irstype="mouse", btype="usb", vnc_passwd=None):
> VirtXML.__init__(self, 'lxc', test_dom, set_uuid(), mem, vcpus)
> - VirtCIM.__init__(self, 'LXC', test_dom, uuid, const.LXC_default_mp,
> - const.LXC_default_source, ntype, net_name, mac, vcpus,
> - mem, const.default_mallocunits, None, grstype,
> - address, port_num, keymap, irstype, btype, vnc_passwd)
> + # pae, acpi and apic parameters doesn't make sense here, so we
> + # statically set them to False (a.k.a. ignore them)
> + VirtCIM.__init__(self, 'LXC', test_dom, uuid, False, False, False,
> + const.LXC_default_mp, const.LXC_default_source, ntype,
> + net_name, mac, vcpus, mem, const.default_mallocunits,
> + None, grstype, address, port_num, keymap, irstype, btype,
This line is over 80 characters. Also, this doesn't apply on updated
sources. Can you rebase this on updated sources?
Thanks!
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com
More information about the Libvirt-cim
mailing list