[Libvirt-cim] [PATCH] [TEST] #2 Update VSMS 14_define_sys_disk.py to use cim_define()

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Feb 4 17:34:05 UTC 2009


>> +#    +# Purpose:
>> +#   Verify providers support disk images with long paths / names
>> +#
>> +# Steps:
>> +#  1) Create a disk image with a long path
>> +#  2) Build RASD parameters, making sure to specify disk image 
>> created in step 1
>> +#  3) Verify guest is defined properly
>>  #
>>
>>   
> Thanks for the description.
> The point 3 is missing from the tc.
> We need to verify for the correctness of the defined guest, we need to 
> verify the disk path that was supplied and atleast the InstanceID using 
> the DiskRASD before undefining the guest.
> Sorry for missing this in the earlier review.

Ah, good point.  What I meant in the comment was - just verify the guest 
is created.  The bug this test case is covering was that the 
DefineSystem() call was failing because the path name was too long.

However, adding some additional verification to this test is a good idea.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list