[Libvirt-cim] [PATCH] [TEST]Fix HostSystem/03_hs_to_settdefcap.py with appropriate number of RASD objects for different platforms

[Guo Lian Yun]

libvirt-cim-bounces at redhat.com wrote on 2009-02-06 07:26:15:

> Kaitlin Rupert wrote:
> >>
> >> diff -r edfa908a60d0 -r 722d799284c3 
> >> suites/libvirt-cim/cimtest/HostSystem/03_hs_to_settdefcap.py
> >> --- a/suites/libvirt-cim/cimtest/HostSystem/03_hs_to_settdefcap.py 
> >> Tue Feb 03 09:37:05 2009 -0800
> >> +++ b/suites/libvirt-cim/cimtest/HostSystem/03_hs_to_settdefcap.py 
> >> Wed Feb 04 21:54:39 2009 -0800
> >> @@ -219,6 +219,9 @@
> >>                  # For Diskpool, we have info 1 for each of Min, Max, 

> >>                  # default, Increment and 1 for each of PV and FV 
> >>                  # hence 4 * 2 = 8 records
> >> +                exp_len = 16
> 
> You need 2 branches here - The value needs to be 8 for: rev >= 707 and 
> rev < 805
> 
> It needs to be 16 if rev >= 805.
> 
> >> +            elif 'DiskPool' in ap['InstanceID'] and virt == 'KVM' 
and \
> >> +                curr_cim_rev >= libvirt_rasd_template_changes:
> >>                  exp_len = 8
> > 
> > These changes were made in rev 805.  So using 
> > libvirt_rasd_template_changes won't work here.
> > 

I fixed it on #2 patch as follows:

Add two branches of returned RASD objects number:
1) The valule to be 8 for Xen when rev >= 707 and rev < 805
2) The value to be 16 for Xen when rev >= 805
3) The value to be 8 for KVM when rev >= 805

> 
> 
> 
> -- 
> Kaitlin Rupert
> IBM Linux Technology Center
> kaitlin at linux.vnet.ibm.com
> 
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20090206/fa28b60d/attachment.htm>