[Libvirt-cim] [PATCH] [TEST] Fix SettingsDefineCapabilities/01_forward.py with appropriate RASD objects for different platforms

[Guo Lian Yun]

libvirt-cim-bounces at redhat.com wrote on 2009-02-06 07:25:55:

> yunguol at cn.ibm.com wrote:
> > # HG changeset patch
> > # User Guolian Yun <yunguol at cn.ibm.com>
> > # Date 1233813653 28800
> > # Node ID 7ee851d72773c17390641ee50ec20387f9af08d1
> > # Parent  edfa908a60d058c7f1ba7394bd1d818999802287
> > [TEST] Fix SettingsDefineCapabilities/01_forward.py with 
> appropriate RASD objects for different platforms
> > 
> > Update the number of returned RASD objects to 16 for Xen, 8 for KVM
> > 
> > Tested for KVM/Xen/LXC with current sources, KVM with F9 rpm.
> > 
> > Signed-off-by: Guolian Yun<yunguol at cn.ibm.com>
> > 
> > diff -r edfa908a60d0 -r 7ee851d72773 suites/libvirt-
> cim/cimtest/SettingsDefineCapabilities/01_forward.py
> > --- a/suites/libvirt-
> cim/cimtest/SettingsDefineCapabilities/01_forward.py   Tue Feb 03 
> 09:37:05 2009 -0800
> > +++ b/suites/libvirt-
> cim/cimtest/SettingsDefineCapabilities/01_forward.py   Wed Feb 04 
> 22:00:53 2009 -0800
> > @@ -176,6 +176,9 @@
> >                  # For Diskpool, we have info 1 for each of Min, Max, 
> >                  # default, Increment and 1 for each of PV and FV 
> >                  # hence 4 * 2 = 8 records
> > +                exp_len = 16
> 
> You need 2 branches here - The value needs to be 8 for: rev >= 707 and 
> rev < 805
> 
> It needs to be 16 if rev >= 805.
> 
> > +            elif 'DiskPool' in instid and virt == 'KVM' and \
> > +                curr_cim_rev >= libvirt_rasd_template_changes:
> >                  exp_len = 8
> 
> Same here - the change was made in version 805.

  I fixed it on #2 patch, the same as HostSystem/03_hs_to_settdefcap.py.
  Thanks!
> 
> -- 
> Kaitlin Rupert
> IBM Linux Technology Center
> kaitlin at linux.vnet.ibm.com
> 
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20090206/5ab4e3e4/attachment.htm>