[Libvirt-cim] [PATCH] [TEST] Update 32_start_reboot.py to use cim_() functions

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Thu Jan 8 23:21:14 UTC 2009


> What I was thinking is to supply the timeout param and maintain a static 
> like variable( that is present in C) and use this static like variable 
> to compare in check_guest_state().
> We can achieve the static behaviour in python by declaring a global 
> variable in the check_guest_state() function. But, I think using globals 
> is highly discouraged ?

Yes, I think it is best to avoid global variables.  It makes the code 
execution more confusing, and they are generally considered less safe.

>> The test case should be responsible for printing its own error message 
>> in the case of a failure, so changing this to info messages shouldn't 
>> be too problematic.
>>
>> The only problem it causes is that when you run with -debug, the info 
>> messages won't print to the terminal, so you'll have to check the 
>> individual log to see why the test failed.
> I think it is better to leave this as it is for now. Since someone might 
> forget to ON the --debug option to see the log messages.

Using the debug option doesn't print info messages to the console. 
Error messages are printed, info messages are not.

I'll continue to do some more brainstorming on this issue.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list