[Libvirt-cim] [PATCH] [TEST] Fix none value for disk assigned for Xen

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Jan 13 20:35:35 UTC 2009


>> +     +    if virt == 'LXC':
>>          d = class_dasd(disk_dev, disk_source, dom_name)
>> -    +    else:
>> +    # Xen's case falls in here using the default values
>> +        d = class_dasd(disk_dev, disk_source, dom_name, emu_type)   
> +1 , but make sure next time we align the comments with the block properly.
>>      class_masd = get_masd_class(virt)
>>      m = class_masd(
>>                  megabytes=mem_mb,
>>   
> The above function call should be aligned as follows.
> m = class_masd(megabytes=mem_mb,
> mallocunits=malloc_units,
> name=dom_name)

I agree with these comments.  Daisy - can you resend the patch with 
these updates?

Thanks!
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list