[Libvirt-cim] [PATCH] [TEST] Don't pass graphics RASD for older provider versions

Deepti B Kalakeri deeptik at linux.vnet.ibm.com
Fri Jan 30 11:55:07 UTC 2009


+1 for me.

Kaitlin Rupert wrote:
> # HG changeset patch
> # User Kaitlin Rupert <karupert at us.ibm.com>
> # Date 1233247066 28800
> # Node ID fd464f0d24d0f4173cefd9d7ee8d27e6fc48ac55
> # Parent  86b52969f91d69a1460f13326b05ca3357ad0599
> [TEST] Don't pass graphics RASD for older provider versions.
>
> GraphicsRASD support was added in provider version 763.
>
> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
>
> diff -r 86b52969f91d -r fd464f0d24d0 suites/libvirt-cim/lib/XenKvmLib/vxml.py
> --- a/suites/libvirt-cim/lib/XenKvmLib/vxml.py	Tue Jan 27 00:41:21 2009 -0800
> +++ b/suites/libvirt-cim/lib/XenKvmLib/vxml.py	Thu Jan 29 08:37:46 2009 -0800
> @@ -47,6 +47,9 @@
>  from CimTest.ReturnCodes import SKIP, PASS, FAIL
>  from XenKvmLib.classes import virt_types, get_typed_class
>  from XenKvmLib.enumclass  import GetInstance
> +from XenKvmLib.const import get_provider_version
> +
> +vsms_graphics_sup = 763
>
>  class XMLClass:
>      xml_string = ""
> @@ -508,8 +511,11 @@
>                  pass
>              else:
>                  res_settings.append(str(self.nasd))
> -        if self.gasd is not None:
> -            res_settings.append(str(self.gasd))
> +
> +        curr_cim_rev, changeset = get_provider_version(self.virt, ip)
> +        if curr_cim_rev >= vsms_graphics_sup:
> +            if self.gasd is not None:
> +                res_settings.append(str(self.gasd))
>
>          if ref_conf is None:
>               ref_conf = ' '
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
>   

-- 
Thanks and Regards,
Deepti B. Kalakeri
IBM Linux Technology Center
deeptik at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list