[Libvirt-cim] [PATCH] [TEST] Fix ComputerSystem/42_cs_gi_errs.py err desc for invalid name

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Thu Mar 5 19:15:16 UTC 2009


> @@ -115,6 +116,11 @@
> 
>          ref = CIMInstanceName(cn, keybindings=keys)
> 
> +        curr_cim_rev, changeset = get_provider_version(options.virt, options.ip)
> +        if tc == 'invalid_name' and curr_cim_rev >= libvirt_err_changes:
> +            expr_values['desc'] = "Referenced domain `invalid_name' \
> +does not exist: Domain not found"
> +

Can you use something like the following instead:

             expr_values['desc'] = "Referenced domain `invalid_name'" + \
                                   " does not exist: Domain not found"

This is much cleaner since it doesn't span 80 characters.
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list