[Libvirt-cim] [PATCH] [TEST]#2 Fix ElementCapabilities/03_forward_errs.py with provider's updated err message

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Mar 10 20:10:14 UTC 2009


Deepti B Kalakeri wrote:
> 
> 
> Kaitlin Rupert wrote:
>>
>>> We should not hardcode CreationClassName to Xen_ComputerSystem.
>>>> +
>>>> +    curr_cim_rev, changeset = get_provider_version(options.virt, 
>>>> options.ip)
>>>> +    if curr_cim_rev >= libvirt_ec_changes:
>>>> +        cs_exp_desc = "Referenced domain `wrong' does not exist:" + \
>>>> +                      " Domain not found"
>>>>   
>>> you dont need a + sign here. \ will work.
>>
>> This is not true in this case.  You'll get the following error:
>>
>> ElementCapabilities/ - 03_forward_errs.py: FAIL
>>   File "03_forward_errs.py", line 92
>>     cs_exp_desc = "Referenced domain `wrong' does not exist:" +
>>                                                               ^
>> SyntaxError: invalid syntax
>>
>> The slash is needed here.
> Sorry for not being clear in the above statement.
> I also meant the same that we dont need a + , instead just using the 
> slash \ will work.
> 

Oh,, no - you were clear.  I misread what you wrote originally.  That's 
my mistake.  Thanks for the clarification!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list