[Libvirt-cim] [PATCH] Allow user to specify whether ACPI should be enabled

[Richard Maciel]

+1

On 11/04/2009 09:30 PM, Kaitlin Rupert wrote:
>>> +static int parse_features(struct domain *dominfo, xmlNode *features)
>>> +{
>>> + xmlNode *child;
>>> +
>>> + for (child = features->children; child != NULL; child = child->next) {
>>> + if (XSTREQ(child->name, "acpi"))
>>> + dominfo->acpi = true;
>>
>> You only check for the acpi property here... (rest of the text is below)
>
> Right now we don't have VSSD attributes for the other features. Those
> will follow in follow up patches.
>
>
>>> + features = xmlNewChild(root, NULL, BAD_CAST "features", NULL);
>>> + if (features == NULL)
>>> + return "Failed to allocate XML memory";
>>> +
>>> + if (domain->type == DOMAIN_XENFV) {
>>> + xmlNewChild(features, NULL, BAD_CAST "pae", NULL);
>>> + xmlNewChild(features, NULL, BAD_CAST "apic", NULL);
>>> + }
>>
>> But you actually create a XML with two more properties (pae and apic).
>> Are these properties always defined for a Xen domain?
>>
>
> Yes, these should always be set for full virt Xen guests. We don't set
> these for para virt Xen, KVM, or LXC guests though.
>
>


-- 
Richard Maciel, MSc
IBM Linux Technology Center
rmaciel at linux.vnet.ibm.com