[Libvirt-cim] [PATCH 5 of 5] [TEST] #3 Add new tc to verify the err values for RPCS DeleteResourceInPool()

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Thu Sep 17 00:57:21 UTC 2009


> +
> +pool_attr = { 'Path' : "/tmp" }
> +vol_name = "cimtest-vol.img"

> +
> + at do_main(platform_sup)
> +def main():
> +    options = main.options
> +    server = options.ip
> +    virt = options.virt
> +
> +    libvirt_ver = virsh_version(server, virt)
> +    cim_rev, changeset = get_provider_version(virt, server)
> +    if libvirt_ver < "0.4.1" and cim_rev < libvirt_rasd_spool_del_changes:
> +        logger.info("Storage Volume deletion support is available with Libvirt"
> +                    "version >= 0.4.1 and Libvirt-CIM rev '%s'", 
> +                    libvirt_rasd_spool_del_changes)
> +        return SKIP
> +
> +    dp_cn = "DiskPool"
> +    exp_vol_path = "%s/%s" % (pool_attr['Path'], vol_name)
> +
> +    pool_name = 'DIR_POOL_VOL'

This test has the same problem as test 10.  You're creating the volume 
in /tmp, and the default pool already uses this location.  So you might 
as well create this volume in the default pool.  No need to create a new 
pool just for this volume.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list