[Libvirt-cim] [PATCH] [TEST] Verify that user can specify target dev for network interfaces

[Deepti B Kalakeri]

Kaitlin Rupert wrote:
> # HG changeset patch
> # User Kaitlin Rupert <karupert at us.ibm.com>
> # Date 1264722478 28800
> # Node ID 9affcdf0161c46cabf18da29f5c9f209d68d9f7b
> # Parent  4bd00149b4a04b6c02efda72e3de45a86c806feb
> [TEST] Verify that user can specify target dev for network interfaces
>
> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
>
> diff -r 4bd00149b4a0 -r 9affcdf0161c suites/libvirt-cim/cimtest/VirtualSystemManagementService/26_definesystem_nic_dev.py
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/26_definesystem_nic_dev.py	Thu Jan 28 15:47:58 2010 -0800
> @@ -0,0 +1,141 @@
> +#!/usr/bin/python
> +#
> +# Copyright 2010 IBM Corp.
> +#
> +# Authors:
> +#    Kaitlin Rupert <karupert at us.ibm.com>
> +#
> +# This library is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public
> +# License as published by the Free Software Foundation; either
> +# version 2.1 of the License, or (at your option) any later version.
> +#
> +# This library is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +# General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public
> +# License along with this library; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
> +#    
> +# Purpose:
> +#   Verify provider's support for specifying the target device for vNICs 
> +#
> +# Steps:
> +#  1) Build RASD parameters, making sure to specify target device for network
> +#     interface 
> +#  2) Create guest
> +#  3) Verify guest is defined properly
> +#
> +
> +import sys
> +from CimTest.Globals import logger
> +from CimTest.ReturnCodes import FAIL, PASS, SKIP
> +from XenKvmLib.classes import get_typed_class, inst_to_mof
> +from XenKvmLib.rasd import get_default_rasds
> +from XenKvmLib.const import do_main, get_provider_version
> +from XenKvmLib.vxml import get_class
> +from XenKvmLib.common_util import parse_instance_id
> +from XenKvmLib.enumclass import EnumInstances
> +
> +sup_types = ['Xen', 'XenFV', 'KVM']
> +test_dom = 'rstest_nic'
> +
> +target_dev_rev = 1026 
> +
> +def get_rasd_list(ip, virt, target_dev):
> +    nrasd_cn = get_typed_class(virt, "NetResourceAllocationSettingData")
> +
> +    rasds = get_default_rasds(ip, virt)
> +
> +    rasd_list = {} 
> +
> +    for rasd in rasds:
> +        if rasd.classname == nrasd_cn and "Default" in rasd['InstanceID']:
> +
> +            rasd['VirtualDevice'] = target_dev
> +
> +        rasd_list[rasd.classname] = inst_to_mof(rasd)
> +
> +    return rasd_list 
> +
> +def verify_net_rasd(ip, virt, target_dev, guest_name):
> +    inst = None
> +
> +    try:
> +        nrasd_cn = get_typed_class(virt, 'NetResourceAllocationSettingData')
> +        enum_list = EnumInstances(ip, nrasd_cn)
> +
> +        if enum_list < 1:
> +            raise Exception("No %s instances returned" % nrasd_cn)
> +
> +        for rasd in enum_list:
> +            guest, dev, status = parse_instance_id(rasd.InstanceID)
> +            if status != PASS:
> +                raise Exception("Unable to parse InstanceID: %s" % \
> +                                rasd.InstanceID)
> +
> +            if guest == guest_name:
> +                inst = rasd 
> +                break
> +
> +        if inst is None:
> +            raise Exception("%s instance for %s not found" % (nrasd_cn, 
> +                            guest_name))
> +
> +        if inst.VirtualDevice != target_dev:
> +            raise Exception("Expected VirtualDevice to be %s" % target_dev)
> +
> +    except Exception, details:
> +        logger.error(details)
> +        return FAIL
> +
> +    return PASS 
> +
> + at do_main(sup_types)
> +def main():
> +    options = main.options
> +
> +    status = FAIL
> +
> +    curr_cim_rev, changeset = get_provider_version(options.virt, options.ip)
> +    if curr_cim_rev < target_dev_rev:
> +        logger.error("Network interface target device support is available" \
> +                     " in rev >= %s", target_dev_rev)
> +        return SKIP
> +
> +    cxml = get_class(options.virt)(test_dom)
> +
> +    target_dev = "vtap7"
>   
We can use a random number in the name here.
We cannot create 2 guests which use the same target device name.
The test would have failed had we tried to start the guest with an error 
similar to the one below:
libvir: QEMU error : Failed to add tap interface 'vtap7' to bridge 
'testbridge3': Device or resource busy

Can we also start the guest in the test case instead of just defining 
the guest ?
> +
> +    guest_defined = False
> +
> +    try:
> +        rasd_list = get_rasd_list(options.ip, options.virt, target_dev)
> +        if len(rasd_list) < 1:
> +            raise Exception("Unable to get template RASDs for %s" % test_dom)
> +
> +        cxml.set_res_settings(rasd_list)
> +        ret = cxml.cim_define(options.ip)
> +        if not ret:
> +            raise Exception("Unable to define %s" % test_dom)
> +
> +        guest_defined = True 
> +
> +        status = verify_net_rasd(options.ip, options.virt, target_dev, test_dom)
> +        if status != PASS:
> +            raise Exception("Failed to net interface for %s" % test_dom)
>   
small typo, "Failed to net" should have been "Failed to add net"

> +
> +    except Exception, details:
> +        logger.error(details)
> +        status = FAIL
> +
> +    if guest_defined == True: 
> +        cxml.undefine(options.ip)
> +
> +    return status 
> +
> +if __name__ == "__main__":
> +    sys.exit(main())
> +    
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
>   

-- 
Thanks and Regards,
Deepti B. Kalakeri
IBM Linux Technology Center
deeptik at linux.vnet.ibm.com