From snmishra at us.ibm.com Mon May 3 16:15:39 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Mon, 3 May 2010 09:15:39 -0700 Subject: [Libvirt-cim] [PATCH] [TEST] Fixing RPCS/10*py to work for libvirt_cim changes < 1032 revision In-Reply-To: <4BDAABDB.3080602@linux.vnet.ibm.com> References: <3d5bb69edc67ab8097a6.1272267658@elm3b151.beaverton.ibm.com> <4BDAABDB.3080602@linux.vnet.ibm.com> Message-ID: +1 Sharad Mishra Open Virtualization Linux Technology Center IBM Deepti B Kalakeri To Sent by: List for discussion and development libvirt-cim-bounc of libvirt CIM es at redhat.com cc 04/30/10 03:07 AM Subject Re: [Libvirt-cim] [PATCH] [TEST] Fixing RPCS/10*py to work for Please respond to libvirt_cim changes < 1032 List for revision discussion and development of libvirt CIM Sharad Mishra wrote: > > Deepti, > > This test is failing on rev 1032. Have you been able to find out why? > The test passed for me with the changes in this patch for Libvirt-CIM 1032 as well. What error did you see ? > > > Thanks > Sharad Mishra > Open Virtualization > Linux Technology Center > IBM > > Inactive hide details for "Deepti B. Kalakeri" ---04/26/2010 12:44:02 > AM---# HG changeset patch"Deepti B. Kalakeri" ---04/26/2010 12:44:02 > AM---# HG changeset patch > > *"Deepti B. Kalakeri" > * > Sent by: libvirt-cim-bounces at redhat.com > > 04/26/2010 12:40 AM > Please respond to > List for discussion and development of libvirt > CIM > > > > To > > libvirt-cim at redhat.com > > cc > > > Subject > > [Libvirt-cim] [PATCH] [TEST] Fixing RPCS/10*py to work for libvirt_cim > changes < 1032 revision > > > > > # HG changeset patch > # User Deepti B. Kalakeri > # Date 1272267529 25200 > # Node ID 3d5bb69edc67ab8097a61cff09927fdf4c5d3f4b > # Parent 456106b86cf4572684877cc923f3af991b4b65bb > [TEST] Fixing RPCS/10*py to work for libvirt_cim changes < 1032 revision > > > The test has been verified with KVM and libvirt-cim rpm for rev<1032 > Signed-off-by: Deepti B. Kalakeri > > diff -r 456106b86cf4 -r 3d5bb69edc67 > suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py > --- > a/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py > Mon Mar 15 09:16:15 2010 -0400 > +++ > b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py > Mon Apr 26 00:38:49 2010 -0700 > @@ -45,6 +45,7 @@ > > pool_attr = { 'Path' : _image_dir } > vol_name = "cimtest-vol.img" > +libvirt_stovol_instance_id=1032 > > def get_template_rasd_from_sdc(virt, server, dp_inst_id): > rasd = None > @@ -231,7 +232,8 @@ > if res[0] != PASS: > raise Exception("Failed to create the Vol %s" % vol_name) > > - if res[1]['Resource']['InstanceID'] != exp_vol_path: > + if res[1]['Resource']['InstanceID'] != exp_vol_path and \ > + cim_rev >= libvirt_stovol_instance_id: > raise Exception("Incorrect InstanceID") > else: > status = PASS > @@ -252,6 +254,8 @@ > > except Exception, details: > logger.error("Exception details: %s", details) > + cleanup_pool_vol(server, virt, pool_name, > + clean_pool, exp_vol_path) > status = FAIL > > return status > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim > > ------------------------------------------------------------------------ > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim -- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik at linux.vnet.ibm.com _______________________________________________ Libvirt-cim mailing list Libvirt-cim at redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: graycol.gif Type: image/gif Size: 105 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: pic13015.gif Type: image/gif Size: 1255 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: ecblank.gif Type: image/gif Size: 45 bytes Desc: not available URL: From cvincent at linux.vnet.ibm.com Tue May 4 18:17:05 2010 From: cvincent at linux.vnet.ibm.com (Chip Vincent) Date: Tue, 04 May 2010 18:17:05 -0000 Subject: [Libvirt-cim] [PATCH] Use CIM 'AllocationUnits' to populate libvirt XML 'capacity unit' AND 'allocation unit' Message-ID: <91c26f188476c9b56aaf.1272997025@bod.raleigh.ibm.com> # HG changeset patch # User Chip Vincent # Date 1272996835 14400 # Node ID 91c26f188476c9b56aaf5536d5f2abb051db9796 # Parent 22a4721a2d978fe611cb75255a094a0cc23abe5c Use CIM 'AllocationUnits' to populate libvirt XML 'capacity unit' AND 'allocation unit' Today, AllocationUnits only maps to capacity unit, which will leave allocation unit as the default (Kb). With this patch, both will be set to the same units. Signed-off-by: Chip Vincent diff -r 22a4721a2d97 -r 91c26f188476 libxkutil/xmlgen.c --- a/libxkutil/xmlgen.c Tue Mar 23 16:31:41 2010 -0700 +++ b/libxkutil/xmlgen.c Tue May 04 14:13:55 2010 -0400 @@ -1138,7 +1138,14 @@ goto out; free(string); - ret = asprintf(&string, "%" PRIu16, vol->cap); + if (vol->cap_units != NULL) { + xmlAttrPtr tmp = NULL; + tmp = xmlNewProp(cap, BAD_CAST "unit", BAD_CAST vol->cap_units); + if (tmp == NULL) + goto out; + } + + ret = asprintf(&string, "%" PRIu16, vol->cap); if (ret == -1) return XML_ERROR; From snmishra at us.ibm.com Tue May 4 22:04:27 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Tue, 4 May 2010 15:04:27 -0700 Subject: [Libvirt-cim] [PATCH] Use CIM 'AllocationUnits' to populate libvirt XML 'capacity unit' AND 'allocation unit' In-Reply-To: <91c26f188476c9b56aaf.1272997025@bod.raleigh.ibm.com> References: <91c26f188476c9b56aaf.1272997025@bod.raleigh.ibm.com> Message-ID: libvirt-cim-bounces at redhat.com wrote on 05/04/2010 11:17:05 AM: > Chip Vincent > Sent by: libvirt-cim-bounces at redhat.com > > 05/04/2010 11:17 AM > > Please respond to > List for discussion and development of libvirt CIM > > To > > libvirt-cim at redhat.com > > cc > > Subject > > [Libvirt-cim] [PATCH] Use CIM 'AllocationUnits' to populate libvirt > XML 'capacity unit' AND 'allocation unit' > > # HG changeset patch > # User Chip Vincent > # Date 1272996835 14400 > # Node ID 91c26f188476c9b56aaf5536d5f2abb051db9796 > # Parent 22a4721a2d978fe611cb75255a094a0cc23abe5c > Use CIM 'AllocationUnits' to populate libvirt XML 'capacity unit' > AND 'allocation unit' > > Today, AllocationUnits only maps to capacity unit, which will leave > allocation unit as the default (Kb). With this patch, both will be > set to the same units. > > Signed-off-by: Chip Vincent > > diff -r 22a4721a2d97 -r 91c26f188476 libxkutil/xmlgen.c > --- a/libxkutil/xmlgen.c Tue Mar 23 16:31:41 2010 -0700 > +++ b/libxkutil/xmlgen.c Tue May 04 14:13:55 2010 -0400 > @@ -1138,7 +1138,14 @@ > goto out; > > free(string); > - ret = asprintf(&string, "%" PRIu16, vol->cap); > + if (vol->cap_units != NULL) { > + xmlAttrPtr tmp = NULL; > + tmp = xmlNewProp(cap, BAD_CAST "unit", BAD_CAST > vol->cap_units); > + if (tmp == NULL) > + goto out; > + } > + > + ret = asprintf(&string, "%" PRIu16, vol->cap); Fix the indentation in the above line (no tabs, but spaces). Otherwise the patch looks good. Haven't tested it. -Sharad > if (ret == -1) > return XML_ERROR; > > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim -------------- next part -------------- An HTML attachment was scrubbed... URL: From cvincent at linux.vnet.ibm.com Wed May 5 03:17:36 2010 From: cvincent at linux.vnet.ibm.com (Chip Vincent) Date: Tue, 04 May 2010 23:17:36 -0400 Subject: [Libvirt-cim] [PATCH] Use CIM 'AllocationUnits' to populate libvirt XML 'capacity unit' AND 'allocation unit' In-Reply-To: References: <91c26f188476c9b56aaf.1272997025@bod.raleigh.ibm.com> Message-ID: <4BE0E350.3060207@linux.vnet.ibm.com> Sharad Mishra wrote: > > libvirt-cim-bounces at redhat.com wrote on 05/04/2010 11:17:05 AM: > > > Chip Vincent > > Sent by: libvirt-cim-bounces at redhat.com > > > > 05/04/2010 11:17 AM > > > > Please respond to > > List for discussion and development of libvirt CIM > > > > > To > > > > libvirt-cim at redhat.com > > > > cc > > > > Subject > > > > [Libvirt-cim] [PATCH] Use CIM 'AllocationUnits' to populate libvirt > > XML 'capacity unit' AND 'allocation unit' > > > > # HG changeset patch > > # User Chip Vincent > > # Date 1272996835 14400 > > # Node ID 91c26f188476c9b56aaf5536d5f2abb051db9796 > > # Parent 22a4721a2d978fe611cb75255a094a0cc23abe5c > > Use CIM 'AllocationUnits' to populate libvirt XML 'capacity unit' > > AND 'allocation unit' > > > > Today, AllocationUnits only maps to capacity unit, which will leave > > allocation unit as the default (Kb). With this patch, both will be > > set to the same units. > > > > Signed-off-by: Chip Vincent > > > > diff -r 22a4721a2d97 -r 91c26f188476 libxkutil/xmlgen.c > > --- a/libxkutil/xmlgen.c Tue Mar 23 16:31:41 2010 -0700 > > +++ b/libxkutil/xmlgen.c Tue May 04 14:13:55 2010 -0400 > > @@ -1138,7 +1138,14 @@ > > goto out; > > > > free(string); > > - ret = asprintf(&string, "%" PRIu16, vol->cap); > > + if (vol->cap_units != NULL) { > > + xmlAttrPtr tmp = NULL; > > + tmp = xmlNewProp(cap, BAD_CAST "unit", BAD_CAST > > vol->cap_units); > > + if (tmp == NULL) > > + goto out; > > + } > > + > > + ret = asprintf(&string, "%" PRIu16, vol->cap); > > Fix the indentation in the above line (no tabs, but spaces). Otherwise > the patch looks good. Haven't tested it. > > -Sharad > Doh. Will fix. > > > > if (ret == -1) > > return XML_ERROR; > > > > > > _______________________________________________ > > Libvirt-cim mailing list > > Libvirt-cim at redhat.com > > https://www.redhat.com/mailman/listinfo/libvirt-cim > > ------------------------------------------------------------------------ > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim -- Chip Vincent Open Virtualization, Linux Technology Center IBM Systems & Technology Group phone: 919-254-4482, T/L 444-4482 email: cvincent at us.ibm.com From cvincent at linux.vnet.ibm.com Wed May 5 17:50:02 2010 From: cvincent at linux.vnet.ibm.com (Chip Vincent) Date: Wed, 05 May 2010 17:50:02 -0000 Subject: [Libvirt-cim] [PATCH] (#2) Use CIM 'AllocationUnits' to populate libvirt XML 'capacity unit' AND 'allocation unit' Message-ID: <293ef309c85b1b1b3551.1273081802@bod.raleigh.ibm.com> # HG changeset patch # User Chip Vincent # Date 1273081753 14400 # Node ID 293ef309c85b1b1b3551366624275d7a9bf6fb59 # Parent 22a4721a2d978fe611cb75255a094a0cc23abe5c (#2) Use CIM 'AllocationUnits' to populate libvirt XML 'capacity unit' AND 'allocation unit' Today, AllocationUnits only maps to capacity unit, which will leave allocation unit as the default (Kb). With this patch, both will be set to the same units. Signed-off-by: Chip Vincent diff -r 22a4721a2d97 -r 293ef309c85b libxkutil/xmlgen.c --- a/libxkutil/xmlgen.c Tue Mar 23 16:31:41 2010 -0700 +++ b/libxkutil/xmlgen.c Wed May 05 13:49:13 2010 -0400 @@ -1138,6 +1138,13 @@ goto out; free(string); + if (vol->cap_units != NULL) { + xmlAttrPtr tmp = NULL; + tmp = xmlNewProp(cap, BAD_CAST "unit", BAD_CAST vol->cap_units); + if (tmp == NULL) + goto out; + } + ret = asprintf(&string, "%" PRIu16, vol->cap); if (ret == -1) return XML_ERROR; From snmishra at us.ibm.com Wed May 5 19:06:34 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Wed, 5 May 2010 12:06:34 -0700 Subject: [Libvirt-cim] [PATCH] (#2) Use CIM 'AllocationUnits' to populate libvirt XML 'capacity unit' AND 'allocation unit' In-Reply-To: <293ef309c85b1b1b3551.1273081802@bod.raleigh.ibm.com> References: <293ef309c85b1b1b3551.1273081802@bod.raleigh.ibm.com> Message-ID: +1 Sharad Mishra Open Virtualization Linux Technology Center IBM libvirt-cim-bounces at redhat.com wrote on 05/05/2010 10:50:02 AM: > Chip Vincent > Sent by: libvirt-cim-bounces at redhat.com > > 05/05/2010 10:50 AM > > Please respond to > List for discussion and development of libvirt CIM > > To > > libvirt-cim at redhat.com > > cc > > Subject > > [Libvirt-cim] [PATCH] (#2) Use CIM 'AllocationUnits' to populate > libvirt XML 'capacity unit' AND 'allocation unit' > > # HG changeset patch > # User Chip Vincent > # Date 1273081753 14400 > # Node ID 293ef309c85b1b1b3551366624275d7a9bf6fb59 > # Parent 22a4721a2d978fe611cb75255a094a0cc23abe5c > (#2) Use CIM 'AllocationUnits' to populate libvirt XML 'capacity > unit' AND 'allocation unit' > > Today, AllocationUnits only maps to capacity unit, which will leave > allocation unit as the default (Kb). With this patch, both will be > set to the same units. > > Signed-off-by: Chip Vincent > > diff -r 22a4721a2d97 -r 293ef309c85b libxkutil/xmlgen.c > --- a/libxkutil/xmlgen.c Tue Mar 23 16:31:41 2010 -0700 > +++ b/libxkutil/xmlgen.c Wed May 05 13:49:13 2010 -0400 > @@ -1138,6 +1138,13 @@ > goto out; > > free(string); > + if (vol->cap_units != NULL) { > + xmlAttrPtr tmp = NULL; > + tmp = xmlNewProp(cap, BAD_CAST "unit", BAD_CAST > vol->cap_units); > + if (tmp == NULL) > + goto out; > + } > + > ret = asprintf(&string, "%" PRIu16, vol->cap); > if (ret == -1) > return XML_ERROR; > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim -------------- next part -------------- An HTML attachment was scrubbed... URL: From deeptik at linux.vnet.ibm.com Fri May 14 10:57:41 2010 From: deeptik at linux.vnet.ibm.com (Deepti B Kalakeri) Date: Fri, 14 May 2010 16:27:41 +0530 Subject: [Libvirt-cim] [PATCH] [TEST] Test macvtap patch In-Reply-To: References: Message-ID: <4BED2CA5.1050001@linux.vnet.ibm.com> +1 -- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik at linux.vnet.ibm.com From deeptik at linux.vnet.ibm.com Mon May 17 11:03:56 2010 From: deeptik at linux.vnet.ibm.com (Deepti B. Kalakeri) Date: Mon, 17 May 2010 04:03:56 -0700 Subject: [Libvirt-cim] [PATCH] [TEST] Fix RPCS/08*py Message-ID: <6ef4afb32928a4f54e5f.1274094236@elm3a148.beaverton.ibm.com> # HG changeset patch # User Deepti B. Kalakeri # Date 1274093983 25200 # Node ID 6ef4afb32928a4f54e5ff7cdb3b0acd2d76da6b5 # Parent 456106b86cf4572684877cc923f3af991b4b65bb [TEST] Fix RPCS/08*py Fix the RPCS/08*py tc to use /var/lib/libvirt/images/ path for creating dik images instead of /tmp The test has been verified with KVM and libvirt-cim current sources Signed-off-by: Deepti B. Kalakeri diff -r 456106b86cf4 -r 6ef4afb32928 suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/08_CreateDiskResourcePool.py --- a/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/08_CreateDiskResourcePool.py Mon Mar 15 09:16:15 2010 -0400 +++ b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/08_CreateDiskResourcePool.py Mon May 17 03:59:43 2010 -0700 @@ -62,7 +62,7 @@ libvirt_netfs_pool_support=869 def get_pool_attr(server, pool_type, dp_types, rev): - pool_attr = { "Path" : "/tmp" } + pool_attr = { "Path" : "/var/lib/libvirt/images/" } if rev >= libvirt_netfs_pool_support and \ pool_type == dp_types['DISK_POOL_NETFS']: From snmishra at us.ibm.com Mon May 17 20:40:50 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Mon, 17 May 2010 13:40:50 -0700 Subject: [Libvirt-cim] [PATCH] [TEST] Fix RPCS/08*py In-Reply-To: <6ef4afb32928a4f54e5f.1274094236@elm3a148.beaverton.ibm.com> References: <6ef4afb32928a4f54e5f.1274094236@elm3a148.beaverton.ibm.com> Message-ID: +1 Sharad Mishra Open Virtualization Linux Technology Center IBM libvirt-cim-bounces at redhat.com wrote on 05/17/2010 04:03:56 AM: > "Deepti B. Kalakeri" > Sent by: libvirt-cim-bounces at redhat.com > > 05/17/2010 04:03 AM > > Please respond to > List for discussion and development of libvirt CIM > > To > > libvirt-cim at redhat.com > > cc > > Subject > > [Libvirt-cim] [PATCH] [TEST] Fix RPCS/08*py > > # HG changeset patch > # User Deepti B. Kalakeri > # Date 1274093983 25200 > # Node ID 6ef4afb32928a4f54e5ff7cdb3b0acd2d76da6b5 > # Parent 456106b86cf4572684877cc923f3af991b4b65bb > [TEST] Fix RPCS/08*py > > Fix the RPCS/08*py tc to use /var/lib/libvirt/images/ path for > creating dik images instead of /tmp > > The test has been verified with KVM and libvirt-cim current sources > Signed-off-by: Deepti B. Kalakeri > > diff -r 456106b86cf4 -r 6ef4afb32928 suites/libvirt-cim/cimtest/ > ResourcePoolConfigurationService/08_CreateDiskResourcePool.py > --- a/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/ > 08_CreateDiskResourcePool.py Mon Mar 15 09:16:15 2010 -0400 > +++ b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/ > 08_CreateDiskResourcePool.py Mon May 17 03:59:43 2010 -0700 > @@ -62,7 +62,7 @@ > libvirt_netfs_pool_support=869 > > def get_pool_attr(server, pool_type, dp_types, rev): > - pool_attr = { "Path" : "/tmp" } > + pool_attr = { "Path" : "/var/lib/libvirt/images/" } > > if rev >= libvirt_netfs_pool_support and \ > pool_type == dp_types['DISK_POOL_NETFS']: > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim -------------- next part -------------- An HTML attachment was scrubbed... URL: From snmishra at us.ibm.com Wed May 19 19:51:09 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Wed, 19 May 2010 19:51:09 -0000 Subject: [Libvirt-cim] [PATCH] Bypass cdrom check while defining VMs Message-ID: <7e986e4a6963fa655d7a.1274298669@elm3b217.beaverton.ibm.com> # HG changeset patch # User Sharad Mishra # Date 1274298264 25200 # Node ID 7e986e4a6963fa655d7a5ee70fd5819ae421471a # Parent 19ce54b3c16676a443c5df53562b0d67294dc04c Bypass cdrom check while defining VMs. Signed-off-by: Sharad Mishra diff -r 19ce54b3c166 -r 7e986e4a6963 src/Virt_VirtualSystemManagementService.c --- a/src/Virt_VirtualSystemManagementService.c Thu May 06 21:22:31 2010 -0400 +++ b/src/Virt_VirtualSystemManagementService.c Wed May 19 12:44:24 2010 -0700 @@ -810,8 +810,11 @@ if (type == VIRT_DISK_TYPE_DISK) dev->dev.disk.device = strdup("disk"); - else if (type == VIRT_DISK_TYPE_CDROM) + else if (type == VIRT_DISK_TYPE_CDROM) { dev->dev.disk.device = strdup("cdrom"); + if (dev->dev.disk.disk_type == DISK_UNKNOWN) + dev->dev.disk.disk_type = DISK_PHY; + } else if (type == VIRT_DISK_TYPE_FLOPPY) dev->dev.disk.device = strdup("floppy"); else From rmaciel at linux.vnet.ibm.com Thu May 20 15:54:51 2010 From: rmaciel at linux.vnet.ibm.com (Richard Maciel) Date: Thu, 20 May 2010 12:54:51 -0300 Subject: [Libvirt-cim] [PATCH] Bypass cdrom check while defining VMs In-Reply-To: <7e986e4a6963fa655d7a.1274298669@elm3b217.beaverton.ibm.com> References: <7e986e4a6963fa655d7a.1274298669@elm3b217.beaverton.ibm.com> Message-ID: <4BF55B4B.1070102@linux.vnet.ibm.com> +1 Em 19-05-2010 16:51, Sharad Mishra escreveu: > # HG changeset patch > # User Sharad Mishra > # Date 1274298264 25200 > # Node ID 7e986e4a6963fa655d7a5ee70fd5819ae421471a > # Parent 19ce54b3c16676a443c5df53562b0d67294dc04c > Bypass cdrom check while defining VMs. > > Signed-off-by: Sharad Mishra > > diff -r 19ce54b3c166 -r 7e986e4a6963 src/Virt_VirtualSystemManagementService.c > --- a/src/Virt_VirtualSystemManagementService.c Thu May 06 21:22:31 2010 -0400 > +++ b/src/Virt_VirtualSystemManagementService.c Wed May 19 12:44:24 2010 -0700 > @@ -810,8 +810,11 @@ > > if (type == VIRT_DISK_TYPE_DISK) > dev->dev.disk.device = strdup("disk"); > - else if (type == VIRT_DISK_TYPE_CDROM) > + else if (type == VIRT_DISK_TYPE_CDROM) { > dev->dev.disk.device = strdup("cdrom"); > + if (dev->dev.disk.disk_type == DISK_UNKNOWN) > + dev->dev.disk.disk_type = DISK_PHY; > + } > else if (type == VIRT_DISK_TYPE_FLOPPY) > dev->dev.disk.device = strdup("floppy"); > else > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim -- Richard Maciel, MSc IBM Linux Technology Center rmaciel at linux.vnet.ibm.com From rmaciel at linux.vnet.ibm.com Thu May 20 15:58:19 2010 From: rmaciel at linux.vnet.ibm.com (Richard Maciel) Date: Thu, 20 May 2010 12:58:19 -0300 Subject: [Libvirt-cim] [PATCH] Generating Deleted indication after Modified indication. In-Reply-To: References: Message-ID: <4BF55C1B.2020209@linux.vnet.ibm.com> Have you tested this? If yes, it looks ok to me. Em 30-04-2010 20:40, Sharad Mishra escreveu: > # HG changeset patch > # User Sharad Mishra > # Date 1269035366 25200 > # Node ID 9147baed9cf8a7bf32a8076d7f98931a940eb59f > # Parent 4ee7c4354bc550780bc02ef1f69fbda387b3fe13 > Generating Deleted indication after Modified indication. > > This patch moves migration job deleted indication after migration job > modified (job completed) indication. > > Signed-off-by: Sharad Mishra > > diff -r 4ee7c4354bc5 -r 9147baed9cf8 src/Virt_VSMigrationService.c > --- a/src/Virt_VSMigrationService.c Tue Mar 02 15:23:45 2010 -0800 > +++ b/src/Virt_VSMigrationService.c Fri Mar 19 14:49:26 2010 -0700 > @@ -1235,7 +1235,6 @@ > } > out: > clear_infstore_migration_flag(dom); > - raise_deleted_ind(job); > > free(uri); > free(xml); > @@ -1266,6 +1265,7 @@ > CIM_JOBSTATE_COMPLETE, > "Completed"); > > + raise_deleted_ind(job); > virConnectClose(job->conn); > free(job->domain); > free(job->ref_cn); > > > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim -- Richard Maciel, MSc IBM Linux Technology Center rmaciel at linux.vnet.ibm.com From snmishra at us.ibm.com Mon May 24 21:49:23 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Mon, 24 May 2010 14:49:23 -0700 Subject: [Libvirt-cim] [PATCH] Include stat.h Message-ID: # HG changeset patch # User Sharad Mishra # Date 1274737698 25200 # Node ID db79e8c20f6217503c7152186fd37751da9ce9ec # Parent 19ce54b3c16676a443c5df53562b0d67294dc04c Include stat.h This file should be included to support *stat* functions. Signed-off-by: Sharad Mishra diff -r 19ce54b3c166 -r db79e8c20f62 libxkutil/infostore.c --- a/libxkutil/infostore.c Thu May 06 21:22:31 2010 -0400 +++ b/libxkutil/infostore.c Mon May 24 14:48:18 2010 -0700 @@ -23,6 +23,7 @@ #include #include #include +#include #include #include From deeptik at linux.vnet.ibm.com Thu May 27 09:10:17 2010 From: deeptik at linux.vnet.ibm.com (Deepti B Kalakeri) Date: Thu, 27 May 2010 14:40:17 +0530 Subject: [Libvirt-cim] [PATCH] Include stat.h In-Reply-To: References: Message-ID: <4BFE36F9.5060203@linux.vnet.ibm.com> Can you do a round of cimtest run to see if this breaks something ? Sharad Mishra wrote: > # HG changeset patch > # User Sharad Mishra > # Date 1274737698 25200 > # Node ID db79e8c20f6217503c7152186fd37751da9ce9ec > # Parent 19ce54b3c16676a443c5df53562b0d67294dc04c > Include stat.h > > This file should be included to support *stat* functions. > > Signed-off-by: Sharad Mishra > > diff -r 19ce54b3c166 -r db79e8c20f62 libxkutil/infostore.c > --- a/libxkutil/infostore.c Thu May 06 21:22:31 2010 -0400 > +++ b/libxkutil/infostore.c Mon May 24 14:48:18 2010 -0700 > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > #include > #include > > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim > -- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik at linux.vnet.ibm.com From snmishra at us.ibm.com Thu May 27 22:00:06 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Thu, 27 May 2010 15:00:06 -0700 Subject: [Libvirt-cim] [PATCH] Workaround for Pegasus ObjectPath issue Message-ID: <49781459fdcfb5cd91eb.1274997606@elm3b151.beaverton.ibm.com> # HG changeset patch # User Sharad Mishra # Date 1274997567 25200 # Node ID 49781459fdcfb5cd91eb7c1e99701d663d5b53eb # Parent 8b1793add36c7e72933c2f8f04c400fa9d3b8910 Workaround for Pegasus ObjectPath issue. Pegasus loses its object path after a call to CMGetObjectPath. This patch adds the object path back to indication. Signed-off-by: Sharad Mishra diff -r 8b1793add36c -r 49781459fdcf src/Virt_ResourceAllocationSettingDataIndication.c --- a/src/Virt_ResourceAllocationSettingDataIndication.c Thu May 27 14:09:56 2010 -0700 +++ b/src/Virt_ResourceAllocationSettingDataIndication.c Thu May 27 14:59:27 2010 -0700 @@ -113,6 +113,10 @@ args->classname = strdup(CLASSNAME(ref)); args->_ctx = _ctx; + /* This is a workaround for Pegasus, it loses its objectpath by + CMGetObjectPath. So set it back. */ + ind->ft->setObjectPath((CMPIInstance *)ind, ref); + s = stdi_deliver(broker, ctx, args, (CMPIInstance *)ind); if (s.rc == CMPI_RC_OK) { CU_DEBUG("Indication delivered"); diff -r 8b1793add36c -r 49781459fdcf src/Virt_VSMigrationService.c --- a/src/Virt_VSMigrationService.c Thu May 27 14:09:56 2010 -0700 +++ b/src/Virt_VSMigrationService.c Thu May 27 14:59:27 2010 -0700 @@ -757,6 +757,11 @@ ind_name = ind_type_to_name(ind_type); ref = CMGetObjectPath(inst, &s); + + /* This is a workaround for Pegasus, it loses its objectpath by + CMGetObjectPath. So set it back. */ + inst->ft->setObjectPath((CMPIInstance *)inst, ref); + if ((ref == NULL) || (s.rc != CMPI_RC_OK)) { CU_DEBUG("Failed to get job reference"); } else {