From cvincent at linux.vnet.ibm.com Wed Sep 15 01:10:02 2010 From: cvincent at linux.vnet.ibm.com (Chip Vincent) Date: Tue, 14 Sep 2010 21:10:02 -0400 Subject: [Libvirt-cim] [PATCH] Adding CMReturnDone after CMPI InvokeMethod In-Reply-To: <8715fb1b3e6c80018347.1282932194@elm3b193.beaverton.ibm.com> References: <8715fb1b3e6c80018347.1282932194@elm3b193.beaverton.ibm.com> Message-ID: <4C901CEA.8030006@linux.vnet.ibm.com> +1. Change pushed upstream. Will rev version and test this week. Sharad Mishra wrote: > # HG changeset patch > # User Sharad Mishra > # Date 1282931870 14400 > # Node ID 8715fb1b3e6c80018347bca07670517e91276b94 > # Parent 72defbefbe6c2abd63e552491c8619989f14e076 > Adding CMReturnDone after CMPI InvokeMethod > > Signed-off-by: Sharad Mishra > > diff -r 72defbefbe6c -r 8715fb1b3e6c std_indication.c > --- a/std_indication.c Sat Jan 16 09:24:30 2010 -0800 > +++ b/std_indication.c Fri Aug 27 13:57:50 2010 -0400 > @@ -311,6 +311,7 @@ > CMPI_RC_ERR_FAILED, > "Invalid method"); > > + CMReturnDone(results); > return s; > } > > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim > -- Chip Vincent Open Virtualization, Linux Technology Center IBM Systems & Technology Group phone: 919-254-4482, T/L 444-4482 email: cvincent at us.ibm.com From snmishra at us.ibm.com Fri Sep 17 19:35:26 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Fri, 17 Sep 2010 12:35:26 -0700 Subject: [Libvirt-cim] How do we track cimtest defects? Message-ID: Hi, Is there a community page to track defects against cimtest? Thanks Sharad Mishra Open Virtualization Linux Technology Center IBM -------------- next part -------------- An HTML attachment was scrubbed... URL: From snmishra at us.ibm.com Fri Sep 17 19:55:31 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Fri, 17 Sep 2010 12:55:31 -0700 Subject: [Libvirt-cim] How do we track cimtest defects? In-Reply-To: References: Message-ID: I found this wiki page - http://wiki.libvirt.org/page/Cimtest_buglist. Is this the one? Sharad Mishra Open Virtualization Linux Technology Center IBM Sharad Mishra/Beaverton/ IBM at IBMUS To Sent by: List for discussion and development libvirt-cim-bounc of libvirt CIM es at redhat.com cc 09/17/2010 12:35 Subject PM [Libvirt-cim] How do we track cimtest defects? Please respond to List for discussion and development of libvirt CIM Hi, Is there a community page to track defects against cimtest? Thanks Sharad Mishra Open Virtualization Linux Technology Center IBM_______________________________________________ Libvirt-cim mailing list Libvirt-cim at redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: graycol.gif Type: image/gif Size: 105 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: pic15447.gif Type: image/gif Size: 1255 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: ecblank.gif Type: image/gif Size: 45 bytes Desc: not available URL: From snmishra at us.ibm.com Fri Sep 17 22:14:27 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Fri, 17 Sep 2010 22:14:27 -0000 Subject: [Libvirt-cim] [PATCH] Do not filter out SBLIM host Message-ID: # HG changeset patch # User Sharad Mishra # Date 1284761568 25200 # Node ID cb30d2782092309e9ce7ae9dc949b4222aa243af # Parent 5dcb6bc27cc6e7fdcb2e595358d523cf29023808 Do not filter out SBLIM host. This patch removes the code that does not return SBLIM host system. The original code did not have this filter and was added later. I searched the archives and did not find any reason to add this code. Signed-off-by: Sharad Mishra diff -r 5dcb6bc27cc6 -r cb30d2782092 src/Virt_HostSystem.c --- a/src/Virt_HostSystem.c Wed Sep 08 16:36:08 2010 -0400 +++ b/src/Virt_HostSystem.c Fri Sep 17 15:12:48 2010 -0700 @@ -237,20 +237,11 @@ { CMPIStatus s = {CMPI_RC_OK, NULL}; CMPIInstance *inst = NULL; - CMPIObjectPath *path = NULL; s = get_host(_BROKER, context, reference, &inst, is_get_inst); if (s.rc != CMPI_RC_OK || inst == NULL) goto out; - path = CMGetObjectPath(inst, &s); - if ((path == NULL) || (s.rc != CMPI_RC_OK)) - return s; - - if (STARTS_WITH(CLASSNAME(path), "Linux_")) - /* Don't return SBLIM instances */ - goto out; - if (name_only) cu_return_instance_name(results, inst); else From snmishra at us.ibm.com Mon Sep 20 17:49:41 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Mon, 20 Sep 2010 17:49:41 -0000 Subject: [Libvirt-cim] [PATCH] (#2) Do not filter out SBLIM host Message-ID: <9cdaa2ce4c1541235182.1285004981@elm3b217.beaverton.ibm.com> # HG changeset patch # User Sharad Mishra # Date 1285004026 25200 # Node ID 9cdaa2ce4c1541235182bf5a8097caffcf0dbcfc # Parent 5dcb6bc27cc6e7fdcb2e595358d523cf29023808 (#2) Do not filter out SBLIM host. This patch removes the code that does not return SBLIM host system. The original code did not have this filter and was added later. I searched the archives and did not find any reason to add this code. Update #2 - Added an else case where if enumeration of instances is null, a fake host is returned. Signed-off-by: Sharad Mishra diff -r 5dcb6bc27cc6 -r 9cdaa2ce4c15 src/Virt_HostSystem.c --- a/src/Virt_HostSystem.c Wed Sep 08 16:36:08 2010 -0400 +++ b/src/Virt_HostSystem.c Mon Sep 20 10:33:46 2010 -0700 @@ -194,6 +194,11 @@ } *inst = data.value.inst; + } else { + cu_statusf(broker, &s, + CMPI_RC_ERR_FAILED, + "No entry found"); + goto out; } out: @@ -237,20 +242,11 @@ { CMPIStatus s = {CMPI_RC_OK, NULL}; CMPIInstance *inst = NULL; - CMPIObjectPath *path = NULL; s = get_host(_BROKER, context, reference, &inst, is_get_inst); if (s.rc != CMPI_RC_OK || inst == NULL) goto out; - path = CMGetObjectPath(inst, &s); - if ((path == NULL) || (s.rc != CMPI_RC_OK)) - return s; - - if (STARTS_WITH(CLASSNAME(path), "Linux_")) - /* Don't return SBLIM instances */ - goto out; - if (name_only) cu_return_instance_name(results, inst); else From deeptik at linux.vnet.ibm.com Mon Sep 20 18:30:01 2010 From: deeptik at linux.vnet.ibm.com (Deepti B Kalakeri) Date: Tue, 21 Sep 2010 00:00:01 +0530 Subject: [Libvirt-cim] How do we track cimtest defects? In-Reply-To: References: Message-ID: <4C97A829.3040809@linux.vnet.ibm.com> Yes Sharad, this is the page where cimtest related problems and to do are listed. Sharad Mishra wrote: > > I found this wiki page - http://wiki.libvirt.org/page/Cimtest_buglist. > Is this the one? > > Sharad Mishra > Open Virtualization > Linux Technology Center > IBM > > Inactive hide details for Sharad Mishra---09/17/2010 12:37:02 > PM---Hi,Sharad Mishra---09/17/2010 12:37:02 PM---Hi, > > *Sharad Mishra/Beaverton/IBM at IBMUS* > Sent by: libvirt-cim-bounces at redhat.com > > 09/17/2010 12:35 PM > Please respond to > List for discussion and development of libvirt > CIM > > > > To > > List for discussion and development of libvirt CIM > > > cc > > > Subject > > [Libvirt-cim] How do we track cimtest defects? > > > > > Hi, > > Is there a community page to track defects against cimtest? > > Thanks > Sharad Mishra > Open Virtualization > Linux Technology Center > IBM_______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim > > ------------------------------------------------------------------------ > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim -- Thanks and Regards, Deepti B. Kalakeri IBM Linux Technology Center deeptik at linux.vnet.ibm.com From cvincent at linux.vnet.ibm.com Thu Sep 23 15:20:02 2010 From: cvincent at linux.vnet.ibm.com (Chip Vincent) Date: Thu, 23 Sep 2010 11:20:02 -0400 Subject: [Libvirt-cim] [PATCH] (#2) Do not filter out SBLIM host In-Reply-To: <9cdaa2ce4c1541235182.1285004981@elm3b217.beaverton.ibm.com> References: <9cdaa2ce4c1541235182.1285004981@elm3b217.beaverton.ibm.com> Message-ID: <4C9B7022.5010004@linux.vnet.ibm.com> Curious why there is code to both fetch and filter out the SBLIM instance. Anyway, the code looks good and has been pushed upstream. +1 Sharad Mishra wrote: > # HG changeset patch > # User Sharad Mishra > # Date 1285004026 25200 > # Node ID 9cdaa2ce4c1541235182bf5a8097caffcf0dbcfc > # Parent 5dcb6bc27cc6e7fdcb2e595358d523cf29023808 > (#2) Do not filter out SBLIM host. > > This patch removes the code that does not return SBLIM host system. > The original code did not have this filter and was added later. > I searched the archives and did not find any reason to add this code. > > Update #2 - Added an else case where if enumeration of instances is null, > a fake host is returned. > > Signed-off-by: Sharad Mishra > > diff -r 5dcb6bc27cc6 -r 9cdaa2ce4c15 src/Virt_HostSystem.c > --- a/src/Virt_HostSystem.c Wed Sep 08 16:36:08 2010 -0400 > +++ b/src/Virt_HostSystem.c Mon Sep 20 10:33:46 2010 -0700 > @@ -194,6 +194,11 @@ > } > > *inst = data.value.inst; > + } else { > + cu_statusf(broker, &s, > + CMPI_RC_ERR_FAILED, > + "No entry found"); > + goto out; > } > > out: > @@ -237,20 +242,11 @@ > { > CMPIStatus s = {CMPI_RC_OK, NULL}; > CMPIInstance *inst = NULL; > - CMPIObjectPath *path = NULL; > > s = get_host(_BROKER, context, reference, &inst, is_get_inst); > if (s.rc != CMPI_RC_OK || inst == NULL) > goto out; > > - path = CMGetObjectPath(inst, &s); > - if ((path == NULL) || (s.rc != CMPI_RC_OK)) > - return s; > - > - if (STARTS_WITH(CLASSNAME(path), "Linux_")) > - /* Don't return SBLIM instances */ > - goto out; > - > if (name_only) > cu_return_instance_name(results, inst); > else > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim > -- Chip Vincent Open Virtualization, Linux Technology Center IBM Systems & Technology Group phone: 919-254-4482, T/L 444-4482 email: cvincent at us.ibm.com From snmishra at us.ibm.com Thu Sep 23 15:44:29 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Thu, 23 Sep 2010 08:44:29 -0700 Subject: [Libvirt-cim] [PATCH] (#2) Do not filter out SBLIM host In-Reply-To: <4C9B7022.5010004@linux.vnet.ibm.com> References: <9cdaa2ce4c1541235182.1285004981@elm3b217.beaverton.ibm.com> <4C9B7022.5010004@linux.vnet.ibm.com> Message-ID: I share your curiosity. I couldn't figure out the reasoning. Searched the libvirt-cim archives to see if there was a note on why it filters out SBLIM instance. I could not find any. I sent an email to the person who made the change. He did not remember either and I don't blame him, since its more than 2 years old code. Regards, Sharad Mishra Open Virtualization Linux Technology Center IBM Chip Vincent To Sent by: List for discussion and development libvirt-cim-bounc of libvirt CIM es at redhat.com cc 09/23/2010 08:20 Subject AM Re: [Libvirt-cim] [PATCH] (#2) Do not filter out SBLIM host Please respond to List for discussion and development of libvirt CIM Curious why there is code to both fetch and filter out the SBLIM instance. Anyway, the code looks good and has been pushed upstream. +1 Sharad Mishra wrote: > # HG changeset patch > # User Sharad Mishra > # Date 1285004026 25200 > # Node ID 9cdaa2ce4c1541235182bf5a8097caffcf0dbcfc > # Parent 5dcb6bc27cc6e7fdcb2e595358d523cf29023808 > (#2) Do not filter out SBLIM host. > > This patch removes the code that does not return SBLIM host system. > The original code did not have this filter and was added later. > I searched the archives and did not find any reason to add this code. > > Update #2 - Added an else case where if enumeration of instances is null, > a fake host is returned. > > Signed-off-by: Sharad Mishra > > diff -r 5dcb6bc27cc6 -r 9cdaa2ce4c15 src/Virt_HostSystem.c > --- a/src/Virt_HostSystem.c Wed Sep 08 16:36:08 2010 -0400 > +++ b/src/Virt_HostSystem.c Mon Sep 20 10:33:46 2010 -0700 > @@ -194,6 +194,11 @@ > } > > *inst = data.value.inst; > + } else { > + cu_statusf(broker, &s, > + CMPI_RC_ERR_FAILED, > + "No entry found"); > + goto out; > } > > out: > @@ -237,20 +242,11 @@ > { > CMPIStatus s = {CMPI_RC_OK, NULL}; > CMPIInstance *inst = NULL; > - CMPIObjectPath *path = NULL; > > s = get_host(_BROKER, context, reference, &inst, is_get_inst); > if (s.rc != CMPI_RC_OK || inst == NULL) > goto out; > > - path = CMGetObjectPath(inst, &s); > - if ((path == NULL) || (s.rc != CMPI_RC_OK)) > - return s; > - > - if (STARTS_WITH(CLASSNAME(path), "Linux_")) > - /* Don't return SBLIM instances */ > - goto out; > - > if (name_only) > cu_return_instance_name(results, inst); > else > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim at redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim > -- Chip Vincent Open Virtualization, Linux Technology Center IBM Systems & Technology Group phone: 919-254-4482, T/L 444-4482 email: cvincent at us.ibm.com _______________________________________________ Libvirt-cim mailing list Libvirt-cim at redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: graycol.gif Type: image/gif Size: 105 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: pic08231.gif Type: image/gif Size: 1255 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: ecblank.gif Type: image/gif Size: 45 bytes Desc: not available URL: From yja at us.ibm.com Fri Sep 24 21:10:35 2010 From: yja at us.ibm.com (Yee Ja) Date: Fri, 24 Sep 2010 16:10:35 -0500 Subject: [Libvirt-cim] dormant vs suspended operating status Message-ID: For KVM, is there any difference between a virtual machine with an operating status of dormant vs suspended, in terms of what functionality is available to run against the virtual machine? It seems as if dormant is the same as suspended, but I haven't read any documentation which specifically indicates such.... Thanks -------------- next part -------------- An HTML attachment was scrubbed... URL: From snmishra at us.ibm.com Thu Sep 30 00:21:43 2010 From: snmishra at us.ibm.com (Sharad Mishra) Date: Thu, 30 Sep 2010 00:21:43 -0000 Subject: [Libvirt-cim] [PATCH] Removing the code to fetch sblim instance Message-ID: <4d59bde40044795f53f0.1285806103@elm3b217.beaverton.ibm.com> # HG changeset patch # User Sharad Mishra # Date 1285806092 25200 # Node ID 4d59bde40044795f53f0a1e53bbf500ceb2b56fa # Parent 2b22040708e97d0634d64d2a7e24205e7d701de3 Removing the code to fetch sblim instance. This instance creates problem while getting that instance. Just returning fake host. Signed-off-by: Sharad Mishra diff -r 2b22040708e9 -r 4d59bde40044 src/Virt_HostSystem.c --- a/src/Virt_HostSystem.c Wed Sep 29 15:34:12 2010 -0700 +++ b/src/Virt_HostSystem.c Wed Sep 29 17:21:32 2010 -0700 @@ -151,66 +151,6 @@ return s; } -static CMPIStatus sblim_host(const CMPIBroker *broker, - const CMPIContext *context, - const CMPIObjectPath *ref, - CMPIInstance **inst) -{ - CMPIObjectPath *path; - CMPIEnumeration *en = NULL; - CMPIData data; - CMPIStatus s; - const char *cn = "Linux_ComputerSystem"; - - path = CMNewObjectPath(broker, "root/cimv2", cn, &s); - if ((path == NULL) || (s.rc != CMPI_RC_OK)) { - cu_statusf(broker, &s, - CMPI_RC_ERR_FAILED, - "Unable to create HostSystem path"); - return s; - } - - /* FIXME: This approach may return the wrong instance if more than - one SBLIM Linux_ComputerSystem instance exists on the system. - This isn't likely to happen in most cases, but a better approach - should be used here. - */ - en = CBEnumInstances(broker, context, path, NULL, &s); - if (en == NULL) { - cu_statusf(broker, &s, - CMPI_RC_ERR_FAILED, - "Upcall EnumInstances of %s class failed", - cn); - goto out; - } - - if (CMHasNext(en, &s)) { - data = CMGetNext(en, &s); - if (CMIsNullObject(data.value.inst)) { - cu_statusf(broker, &s, - CMPI_RC_ERR_FAILED, - "Failed to retrieve enumeration entry"); - goto out; - } - - *inst = data.value.inst; - } else { - cu_statusf(broker, &s, - CMPI_RC_ERR_FAILED, - "No entry found"); - goto out; - } - - out: - if (s.rc != CMPI_RC_OK) { - CU_DEBUG("SBLIM: %i %s", s.rc, CMGetCharPtr(s.msg)); - } else { - CU_DEBUG("SBLIM: Returned instance"); - } - - return s; -} - CMPIStatus get_host(const CMPIBroker *broker, const CMPIContext *context, const CMPIObjectPath *reference, @@ -219,10 +159,6 @@ { CMPIStatus s; - s = sblim_host(broker, context, reference, _inst); - if (s.rc != CMPI_RC_OK) - s = fake_host(broker, reference, _inst); - if (!is_get_inst && (s.rc == CMPI_RC_ERR_NOT_FOUND)) { /* This is not an error */ return (CMPIStatus){CMPI_RC_OK, NULL};