[Libvirt-cim] [PATCH] [TEST] Conditionally fail this test if QEMU command 'device_add' fails

[Chip Vincent]

+1. The code change looks correct, but this test always fails on my 
system. Basically, I get an out-of-memory error from deep down within 
cimtest. I'll try to reproduce on another system and open a defect to 
track, if needed.

On 04/04/2011 03:46 PM, Sharad Mishra wrote:
> # HG changeset patch
> # User Sharad Mishra<snmishra at us.ibm.com>
> # Date 1301946359 25200
> # Node ID 96ef3d9cdb65d32f54fce85d5c154cd84466ea24
> # Parent  4d2dc8ffbd280bf988c7fa9c9bc08d87785dec72
> [TEST] Conditionally fail this test if QEMU command 'device_add' fails.
>
> This test will fail if hotplugging is not supported.
>
> Signed-off-by: Sharad Mishra<snmishra at us.ibm.com>
>
> diff -r 4d2dc8ffbd28 -r 96ef3d9cdb65 suites/libvirt-cim/cimtest/VirtualSystemManagementService/30_dynamic_disk_mod.py
> --- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/30_dynamic_disk_mod.py	Mon Apr 04 12:42:52 2011 -0700
> +++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/30_dynamic_disk_mod.py	Mon Apr 04 12:45:59 2011 -0700
> @@ -28,7 +28,7 @@
>   from XenKvmLib.classes import get_typed_class
>   from CimTest.Globals import logger
>   from XenKvmLib.const import do_main
> -from CimTest.ReturnCodes import FAIL, PASS
> +from CimTest.ReturnCodes import FAIL, PASS, XFAIL
>   from XenKvmLib import vsms_util
>
>   sup_types = ['Xen', 'KVM', 'XenFV']
> @@ -72,7 +72,7 @@
>       status = vsms_util.add_disk_res(options.ip, service, cxml, vssd_ref,
>                                       dasd, disk_attr)
>       if status != PASS:
> -        return FAIL
> +        return XFAIL
>       dasd = vsms.get_dasd_class(options.virt)(dev='vdc',
>                                            instanceid='rstest_domain/vda',
>                                            source='/home/rss.iso',
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim

-- 
Chip Vincent
Open Virtualization
IBM Linux Technology Center
cvincent at linux.vnet.ibm.com