[Libvirt-cim] [PATCH 2/2] ComputerSystemIndication: Support libvirt domain events

[Eduardo Lima (Etrunko)]

On 12/30/2011 09:24 AM, Wayne Xia wrote:
>    viewed the codes and no obvious problem found. Just one thing
> uncertain: this require libvirt0.9.0, does this affect existing user
> who have not latest libvirt installed? If not maybe old code should be
> kept.

Yes, As I stated on the patch description, those API's were introduced
in libvirt 0.9.0. That is the reason of the requirement, otherwise the
code won't compile at all.

If you read the patch, you will notice the changes impact the code too
much. It is basically removing everything that was done manually by
libvirt-cim and adding the hooks that libvirt requires.

The way to make it work with older versions of libvirt is by
implementing the event loop ourselves and registering that
implementation with libvirt via the virEventRegisterImpl.

>    And is there some expected result I can get in wbemexec or wbemcli
>  to test the patch easily? 

I am not aware of a simple way to test this. I was running the
ComputerSystemIndication test case in cimtest.

-- 
Eduardo de Barros Lima
Software Engineer, Open Virtualization
Linux Technology Center - IBM/Brazil
eblima at br.ibm.com