[Libvirt-cim] [PATCH] [TEST] Memory is calculated in block sizes

Chip Vincent cvincent at linux.vnet.ibm.com
Fri Feb 18 01:44:24 UTC 2011


+1.

In the future, let's use either dyanmic block size (since it may vary) 
or code it such that "nmen = 256 * 512" so the code is somewhat "self 
documenting" :)

On 01/14/2011 10:52 AM, Sharad Mishra wote:
> # HG changeset patch
> # User Sharad Mishra<snmishra at us.ibm.com>
> # Date 1295019233 28800
> # Node ID a99191b4a4f499c452cb50558b87f9c03925f1f2
> # Parent  8866ff769a7637cbee7c793827152649856815f2
> [TEST] Memory is calculated in block sizes.
>
> This test was modifying the VM memory and then
> verify that the new memory size matches the expected
> memory. The test was failing because memory was not
> getting multiplied by the block size (512). Updated this
> test to account for  memory size in blocks.
>
> Signed-off-by: Sharad Mishra<snmishra at us.ibm.com>
>
> diff -r 8866ff769a76 -r a99191b4a4f4 suites/libvirt-cim/cimtest/RASDIndications/02_guest_add_mod_rem_rasd_ind.py
> --- a/suites/libvirt-cim/cimtest/RASDIndications/02_guest_add_mod_rem_rasd_ind.py	Fri Jan 14 07:25:16 2011 -0800
> +++ b/suites/libvirt-cim/cimtest/RASDIndications/02_guest_add_mod_rem_rasd_ind.py	Fri Jan 14 07:33:53 2011 -0800
> @@ -45,7 +45,7 @@
>   sup_types = ['KVM', 'Xen', 'XenFV']
>   libvirt_guest_rasd_indication_rev = 980
>
> -nmem = 256
> +nmem = 131072
>   nmac = '00:11:22:33:44:55'
>
>   def create_guest(test_dom, ip, virt, cxml):
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim




More information about the Libvirt-cim mailing list