[Libvirt-cim] [PATCH] Ensure graphics devices have unique IDs

Tue May 17 18:48:08 UTC 2011

On 05/11/2011 01:39 PM, Chip Vincent wrote:
> # HG changeset patch
> # User Chip Vincent<cvincent at us.ibm.com>
> # Date 1305131981 14400
> # Node ID 90f8c9f2388e0563baa311c84024ca41a61e1890
> # Parent  8b428df21c360d1eaedba7157b0dfd429d2db121
> Ensure graphics devices have unique IDs
>
> Now that multiple graphics device types are supported, it important that they have unique names that are consistent over time. This patch updates the graphics->id to replace 'graphics' with<graphics_type>  for vnc and<graphics_type>:<port>  for serial/console. The port is ommitted from vnc connections because it changes when VM started if autoport is enabled and only one connection is currently supported. The source path is ommitted from serial/console connections because it is present only when the VM is running. Since libvirt limits the number of serial/console pty resources and ensures they have unique ports, the source path is not necessary to ensure consistent unique names.
>
> Examples of new graphics id format:
> InstanceID="test_domain/serial:0"
> InstanceID="test_domain/serial:1"
> InstanceID="test_domain/console:0"
> InstanceID="test_domain/vnc"
>

After struggling with the setup on my machine, I have finally been able 
to test the patch. It looks like the patch is ok, but somehow I do not 
get a vnc instance with wbemcli, even though virsh dumpxml shows it. See 
the outupt in attached file.

Best regards, Etrunko.

-- 
Eduardo de Barros Lima
Software Engineer, Open Virtualization
Linux Technology Center - IBM/Brazil
eblima at br.ibm.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: outuput.txt
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20110517/4fcb3474/attachment.txt>