[Libvirt-cim] [PATCH 2 of 2] [TEST] XenKvmLib: Add cdrom device description to domain

[Eduardo Lima (Etrunko)]

On 10/13/2011 09:37 AM, Chip Vincent wrote:
> # ll /var/lib/libvirt/images
> total 16844232
> -rw------- 1 root root     372736 Sep 30 14:21 cdrom01.iso
> -rw------- 1 root root     372736 Sep 30 14:21 cdrom02.iso
> 
> 
> After extracting the .iso files and applying both patches, I get the
> following error:
> 
> Testing KVM hypervisor
> --------------------------------------------------------------------
> VirtualSystemManagementService - 32_modify_cdrom_media.py: FAIL
> ERROR     - New media '/var/lib/libvirt/images/cdrom01.iso' does not
> match expected ''

This may be related to the version of pegasus you have installed in your
machine. This test case is very similar to the 31_unset_netrasd that I
have posted. It will issue a ModifyResourceSettings call with an empty
string to eject the media. See my previous email on the thread about the
unset_netrasd patch.

> ERROR     - TypeError : 'NoneType' object is unsubscriptable
> Traceback (most recent call last):
>   File
> "/home/cvincent/proj/dev/tmp/cimtest/suites/libvirt-cim/lib/XenKvmLib/const.py",
> line 141, in do_try
>     rc = f()
>   File "32_modify_cdrom_media.py", line 209, in main
>     inst = modify_media(cim, inst, media_path)
>   File "32_modify_cdrom_media.py", line 100, in modify_media
>     val = set_device_addr(inst, addr)
>   File "32_modify_cdrom_media.py", line 83, in set_device_addr
>     inst["InstanceID"],
> TypeError: 'NoneType' object is unsubscriptable
> ERROR     - None
> --------------------------------------------------------------------

Now about this error, I see an oportunity of an extra check for None in
order to avoid this traceback. There are also a few small syntax fixes
elsewhere that I will post later on today.

Best regards, Etrunko

-- 
Eduardo de Barros Lima
Software Engineer, Open Virtualization
Linux Technology Center - IBM/Brazil
eblima at br.ibm.com