[Libvirt-cim] [PATCH v6 0/3] Implementation of a linked list helper

Sharad Mishra snmishra at linux.vnet.ibm.com
Thu Feb 2 18:38:14 UTC 2012


+1 

run cimtest before pushing.

-Sharad

On Tue, 2012-01-31 at 19:58 -0200, Eduardo Lima (Etrunko) wrote:
> From: "Eduardo Lima (Etrunko)" <eblima at br.ibm.com>
> 
> This series provides a generic linked list implementation for libxkutil that is
> based on the one originally developed for the libvirt domain events support
> recently integrated upstream.
> 
> As test case I ported the ComputerSystemIndication provider code to use this
> list implementation. In the near future it will be also used by the event loop
> that I am currently working on to allow systems with libvirt older than 0.9.0
> to make use of the same feature.
> 
> Other possible use cases would be to port the code of libxkutil/*_parsing* to
> also use the list implementation instead of static arrays.
> 
> Changes from v5:
>  - Fix possible NULL dereference in list_first()
> 
> Changes from v4:
>  - Fix possible NULL dereference in list_last_node()
>  - Fix possible leak in acl_parsing.c
> 
> Changes from v3:
>  - Fix crashes in list_free(), list_first_node() and list_count()
>  - Include patch that ports the acl filter ref code to use the linked list
>    implementation
> 
> Changes from v2:
>  - Make list struct private
> 
> Changes from v1:
>  - Fix version iformation in Makefile.am
> 
> Eduardo Lima (Etrunko) (3):
>   libxkutil: Linked list helper
>   CSI: Use list helper implementation
>   ACL: Use linked list helper for filter refs
> 
>  libxkutil/Makefile.am               |   51 +++++--
>  libxkutil/acl_parsing.c             |   58 +++------
>  libxkutil/acl_parsing.h             |    5 +-
>  libxkutil/list_util.c               |  254 +++++++++++++++++++++++++++++++++++
>  libxkutil/list_util.h               |   73 ++++++++++
>  libxkutil/xmlgen.c                  |   30 +++-
>  src/Virt_ComputerSystemIndication.c |   95 ++++----------
>  src/Virt_NestedFilterList.c         |   73 ++++++-----
>  8 files changed, 472 insertions(+), 167 deletions(-)
>  create mode 100644 libxkutil/list_util.c
>  create mode 100644 libxkutil/list_util.h
> 





More information about the Libvirt-cim mailing list