[Libvirt-cim] [PATCH] libcmpiutil: Fix endianness issues in embedded object parsing

John Ferlan jferlan at redhat.com
Thu Aug 8 22:25:36 UTC 2013


On 08/08/2013 09:27 AM, Viktor Mihajlovski wrote:
> From: Thilo Boehm <tboehm at linux.vnet.ibm.com>
> 
> The auxiliary functions _set_int_prop/parse_int_property only
> worked on little-endian archs as they performed an incorrect
> reinterpretation of 64bit integers. Fixed by using the proper
> CMPIValue union fields.
> 
> Signed-off-by: Thilo Boehm <tboehm at linux.vnet.ibm.com>
> Signed-off-by: Viktor Mihajlovski <mihajlov at linux.vnet.ibm.com>
> ---
>  eo_parser.c     |   35 ++++++++++++++++++++++-------------
>  eo_parser_xml.c |   49 +++++++++++++++++++++++++++++++++++++++----------
>  2 files changed, 61 insertions(+), 23 deletions(-)
> 

Seems fine to me... I assume one author and one reviewer, right?
I'd say push away.

John




More information about the Libvirt-cim mailing list