[Libvirt-cim] [PATCH] libcmpiutil: Fix endianness issues in embedded object parsing

[John Ferlan]

On 08/09/2013 02:19 AM, Viktor Mihajlovski wrote:
> On 08/09/2013 12:25 AM, John Ferlan wrote:
>> On 08/08/2013 09:27 AM, Viktor Mihajlovski wrote:
>>> From: Thilo Boehm <tboehm at linux.vnet.ibm.com>
>>>
>>> The auxiliary functions _set_int_prop/parse_int_property only
>>> worked on little-endian archs as they performed an incorrect
>>> reinterpretation of 64bit integers. Fixed by using the proper
>>> CMPIValue union fields.
>>>
>>> Signed-off-by: Thilo Boehm <tboehm at linux.vnet.ibm.com>
>>> Signed-off-by: Viktor Mihajlovski <mihajlov at linux.vnet.ibm.com>
>>> ---
>>>   eo_parser.c     |   35 ++++++++++++++++++++++-------------
>>>   eo_parser_xml.c |   49
>>> +++++++++++++++++++++++++++++++++++++++----------
>>>   2 files changed, 61 insertions(+), 23 deletions(-)
>>>
>>
>> Seems fine to me... I assume one author and one reviewer, right?
> Right, Thilo is the principal author and I have applied only minor
> editorial changes to the commit message (hence my signoff).
>> I'd say push away.
> Thanks, but I fear I am depending on your kind help here ;-).
> 
> As a heads up: this patch is - so to speak - a portent of more
> (mainly but not only s390 arch related) to come. Unfortunately
> we were not able to make it in time for the recent release.
> 

I pushed the change after making an edit to remove the trailing white
space in a few lines of eo_parser_xml.c (each of the case #: entries had
trailing white space and git am complains).

John