[Libvirt-cim] [PATCH 1/4] VSSD: Add properties for arch and machine

[John Ferlan]

On 08/15/2013 10:48 AM, Viktor Mihajlovski wrote:
> For architectures like s390 the machine type is relevant for
> the proper guest construction. We add the necessary properties
> to the schema and the C structures and the necessary code
> for CIM-to-libvirt mapping.
> 
> While doing this I noticed that the union fields in os_info
> were set by means of XML parsing which doesn't take into account
> that certain fields are depending on the virtualization type.
> This could lead both to memory overwrites and memory leaks.
> Fixed by using temporary variables and type-based setting of fields
> 
> Signed-off-by: Viktor Mihajlovski <mihajlov at linux.vnet.ibm.com>
> ---
>  libxkutil/device_parsing.c                |   85 ++++++++++++++++++++++-------
>  libxkutil/device_parsing.h                |    2 +
>  libxkutil/xmlgen.c                        |    6 ++
>  schema/VSSD.mof                           |    6 ++
>  src/Virt_VSSD.c                           |    9 +++
>  src/Virt_VirtualSystemManagementService.c |   14 +++++
>  6 files changed, 101 insertions(+), 21 deletions(-)
> 

ACK

John

(Working my way through the set now)