[Libvirt-cim] [PATCH 00/19] Resolve Coverity warnings

[John Ferlan]

On 05/16/2013 10:57 AM, John Ferlan wrote:
> The following set of patches resolve a number of Coverity errors/warnings
> that have crept into the code.  After these changes there will be zero
> warnings
> 
> John Ferlan (19):
>   Coverity: Resolve BAD_COMPARE - ActivateFilter()
>   Coverity: Resolve CHECKED_RETURN - _generic_infostore_open()
>   Coverity: Resolve CHECKED_RETURN - filter_by_pool()
>   Coverity: Resolve CHECKED_RETURN - get_dev_from_pool
>   Coverity: Resolve CHECKED_RETURN - get_pools()
>   Coverity: Resolve CHECKED_RETURN - mem_rasd_to_vdev()
>   Coverity: Resolve CHECKED_RETURN - return_enum_rasds()
>   Coverity: Resolve DEADCODE - do_parse()
>   Coverity: Resolve DEADCODE - get_hypervisor_enabled()
>   Coverity: Resolve DEADCODE - octets_from_ip()
>   Coverity: Resolve NO_EFFECT - set_proc_rasd_params()
>   Coverity: Resolve NO_EFFECT - _set_fv_prop()
>   Coverity: Resolve RESOURCE_LEAK - parse_os()
>   Coverity: Resolve REVERSE_INULL - doms_to_xml()
>   Coverity: Resolve REVERSE_INULL - lifecycle_thread_native()
>   Coverity: Resolve UNINIT - vsss_delete_snapshot()
>   Coverity: Resolve UNUSED_VALUE - system_xml() && mem_xml()
>   Coverity: Resolve USE_AFTER_FREE - lifecycle_thread_native()
>   Coverity: Resolve ARRAY_VS_SINGLETON - get_dev_paths() and callers
> 
>  libxkutil/device_parsing.c                  |  8 +++++++-
>  libxkutil/infostore.c                       |  5 ++++-
>  libxkutil/misc_util.c                       |  4 ++--
>  libxkutil/xmlgen.c                          | 16 ++++++++++++++++
>  src/Virt_ComputerSystemIndication.c         | 19 +++++++++++++------
>  src/Virt_ElementAllocatedFromPool.c         | 12 +++++++-----
>  src/Virt_FilterEntry.c                      |  3 ---
>  src/Virt_RASD.c                             | 20 ++++++++++++++------
>  src/Virt_ResourceAllocationFromPool.c       |  4 +++-
>  src/Virt_ResourcePoolConfigurationService.c | 20 +++++++-------------
>  src/Virt_VSSD.c                             |  2 +-
>  src/Virt_VirtualSystemManagementService.c   |  4 +++-
>  src/Virt_VirtualSystemSnapshotService.c     |  2 +-
>  13 files changed, 78 insertions(+), 41 deletions(-)
> 

After resolving a couple of issues with the changes in 6/19 and 11/19, I
have pushed these.

There are zero Coverity errors using the default aggressiveness for
cov-analyze.

John