[Libvirt-cim] [PATCH V5 03/15] SDC: use property BootDevices instead of BootDevice

John Ferlan jferlan at redhat.com
Thu Mar 21 17:00:33 UTC 2013


On 03/20/2013 11:39 PM, Wenchao Xia wrote:
>   The property registerted is BootDevices, so correct it.
> 
> Signed-off-by: Wenchao Xia <xiawenc at linux.vnet.ibm.com>
> ---
>  src/Virt_SettingsDefineCapabilities.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/Virt_SettingsDefineCapabilities.c b/src/Virt_SettingsDefineCapabilities.c
> index 5091205..1e7a778 100644
> --- a/src/Virt_SettingsDefineCapabilities.c
> +++ b/src/Virt_SettingsDefineCapabilities.c
> @@ -172,7 +172,7 @@ static CMPIStatus _xen_vsmc_to_vssd(virConnectPtr conn,
>                  if (inst == NULL)
>                          goto error;
>  
> -                CMSetProperty(inst, "BootDevice",
> +                CMSetProperty(inst, "BootDevices",
>                                (CMPIValue *)"hda", CMPI_chars);
>  
>                  CMSetProperty(inst, "isFullVirt",
> @@ -211,7 +211,7 @@ static CMPIStatus _kvm_vsmc_to_vssd(virConnectPtr conn,
>          CMSetProperty(inst, "VirtualSystemIdentifier",
>                        (CMPIValue *)"KVM_guest", CMPI_chars);
>  
> -        CMSetProperty(inst, "BootDevice",
> +        CMSetProperty(inst, "BootDevices",
>                        (CMPIValue *)"hda", CMPI_chars);
>  
>          inst_list_add(list, inst);
> 

ACK

Note: In this module, the "isFullVirt" is used - hence my follow-up
question to patch 2/15.

I also found two instances where "BootDevice" is used in CU_DEBUG
messages (not that it matters, but it's a consistency thing for me).

John




More information about the Libvirt-cim mailing list