[Libvirt-cim] [PATCH V6 00/20] Bug fix patches for 0.6.2

[John Ferlan]

On 03/25/2013 05:52 AM, Wenchao Xia wrote:
>   This serial fix a batch of issues.
> 
> v6:
>   general change:
>   rebase and add John Ferlan's patches after the tail. 
>   2/20: do not add this property now, just fixed the spelling in code, since
> it is only set when Xen is used in libvirt-cim, so it is OK.
>   3/20: also fixed debug print spelling.
>   5/20: squashed patch for debug print crash issues.
>   6/20: spelling fix in commit message.
>   7/20: skipped free_diskpool on fail of setting parent pool, refined the
> code in get_diskpool_config() when libvirt pool was not used, removed the
> duplicated macro in .c file, set member to NULL in parse_diskpool_line when
> fail.
>   8/20: squashed the patch with John Ferlan's one about "adjust logic" for it.
>   11/20: free the domain ptr after domain name retrieving.
>   13/20: rename no_root_ssh_key to use_non_root_ssh_key, fail when file can't
> be deleted before copy in ssh_key_copy().
>   17/20: small code style change for {} in if condition.
>   18/20: added a macro to activate it.
>   19/20: added three macro to activate them, added {} in if statement when
> only one sentence follow.
> 
> John Ferlan (7):
>   14 Makefile.am: Remove the $(top_srcdir) from subst command
>   15 libvirt-cim.spec: Use systemctl for tog-pegasus restart
>   16 Remove empty newline at bottom
>   17 xmlgen: Only support script on bridge for xen domains
>   18 libxkutil: Use virConnectListAllDomains() to fetch domains
>   19 DevicePool: Use the virConnectListAll interfaces
>   20 register: Adjust the chatter output
> 
> Wenchao Xia (13):
>   1 Remove property CreationClassName in some instance
>   2 SDC: Fix spelling for property IsFullVirt
>   3 SDC: use property BootDevices instead of BootDevice
>   4 do not deregister virt classes in yum upgrade
>   5 CSI, DevicePool, RASDIndication: fix debug print crash
>   6 CSI, add lock to protect shared data in lifecycle_thread
>   7 DevicePool, reimplement get_diskpool_config with libvirt
>   8 device parsing, add debug print
>   9 CSI Discard libvirt event by default
>   10 CSI: Move native CSI code together
>   11 VSSD: report success if not all VS fail in enum
>   12 misc_util: better way to read config
>   13 migration: allow ssh based migration with non root's key file
> 
>  Makefile.am                                        |   18 +-
>  libvirt-cim.conf                                   |   19 +
>  libvirt-cim.spec.in                                |   24 +-
>  libxkutil/cs_util_instance.c                       |   26 +
>  libxkutil/device_parsing.c                         |   19 +-
>  libxkutil/misc_util.c                              |  135 +++-
>  libxkutil/misc_util.h                              |    6 +-
>  libxkutil/xmlgen.c                                 |   26 +-
>  provider-register.sh                               |    9 +-
>  schema/SwitchService.registration                  |    1 -
>  src/Virt_AllocationCapabilities.c                  |    3 +-
>  src/Virt_ComputerSystem.c                          |   66 ++-
>  src/Virt_ComputerSystemIndication.c                | 1018 +++++++++++++++++---
>  src/Virt_ConsoleRedirectionService.c               |    3 +-
>  src/Virt_ConsoleRedirectionServiceCapabilities.c   |    3 +-
>  src/Virt_Device.c                                  |   18 +-
>  src/Virt_DevicePool.c                              |  480 ++++++++--
>  src/Virt_DevicePool.h                              |    4 +
>  src/Virt_EnabledLogicalElementCapabilities.c       |    3 +-
>  src/Virt_FilterEntry.c                             |    3 +-
>  src/Virt_FilterList.c                              |    3 +-
>  src/Virt_HostSystem.c                              |    3 +-
>  src/Virt_KVMRedirectionSAP.c                       |    3 +-
>  src/Virt_RASD.c                                    |    3 +-
>  src/Virt_ReferencedProfile.c                       |    3 +-
>  src/Virt_RegisteredProfile.c                       |    3 +-
>  src/Virt_ResourceAllocationSettingDataIndication.c |    6 +-
>  src/Virt_ResourcePoolConfigurationCapabilities.c   |    3 +-
>  src/Virt_ResourcePoolConfigurationService.c        |    8 +-
>  src/Virt_SettingsDefineCapabilities.c              |   14 +-
>  src/Virt_SwitchService.c                           |    3 +-
>  src/Virt_VSMigrationCapabilities.c                 |    3 +-
>  src/Virt_VSMigrationService.c                      |  270 +++++-
>  src/Virt_VSMigrationSettingData.c                  |    3 +-
>  src/Virt_VSSD.c                                    |   50 +-
>  src/Virt_VirtualSystemManagementCapabilities.c     |    3 +-
>  src/Virt_VirtualSystemManagementService.c          |   67 ++-
>  src/Virt_VirtualSystemSnapshotService.c            |    3 +-
>  ...Virt_VirtualSystemSnapshotServiceCapabilities.c |    3 +-
>  39 files changed, 1990 insertions(+), 348 deletions(-)
> 
> 

ACK on series.  There were a couple of grammar things seen in commit
messages and comments, but nothing that isn't understandable ;-)

I was able to test using my fedora box, but haven't had the cycles to do
the same on the rh64 box. With my cimtest changes I am down to very few
errors now - mostly config type stuff (indications don't work for me and
I don't have the right setup for a couple of network tests).

John