[Libvirt-cim] [PATCH] Make sure provider revision is a number

[Viktor Mihajlovski]

On 10/02/2013 03:46 PM, John Ferlan wrote:
...
>
> To "fix" I changed the "(rev, changeset)" to "(rev, str(changeset))"
>
> I adjusted and pushed.
thanks
...
>
> I'm not a "build guru", but I think the libvirt-cim build probably needs
> to generate the values more frequently than just in autoconfiscate.sh
> seeing as that's 'perhaps' run less frequently than  someone making
> changes to the git repository and rebuilding...
I agree it is a bit tricky in development environments, in the
long run however I think it's correct to calculate the 'official'
revision only during full (RPM) builds from GIT master.
The problem is that everyone is typically working from private
branches which tend to be 'longer' than master.
A section in a cimtest README explaining the ramifications
might help though...

-- 

Mit freundlichen Grüßen/Kind Regards
    Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294