[Libvirt-cim] [PATCH 0/8] Support for full function consoles

[John Ferlan]

On 09/10/2013 12:21 PM, Viktor Mihajlovski wrote:

> as I have pointed out before, the VSSC_dom
> is plainly defined without a console by the testsuite, so it is perfectly correct
> for it not to show up above.
> Which means that the 03_xxx testcase is broken, as it should check whether the
> domain has the RASDs that are to be expected instead of a RASD of each type
> discovered on the system. Will try to fix this as well in the cimtest patch
> I'm working on
> 

So essentially the following test is completely bogus as it's not
testing anything other than a domain having all types of available
RASDs in the environment:

    if len(rasds) != len(rasd_insts):
        logger.error("Expected %d RASDs, got %d", len(rasds), len(rasd_insts)) 
        return rasd_insts, FAIL

If anything what it should be doing is

    if (len(rasds_insts == 0):
        logger.error("Found 0 RASDs for %s", guest_name) 
        return rasd_insts, FAIL

Not quite sure how one would determine how many are expected though
without knowing a bit more about the definition of the guest.


John