[Libvirt-cim] [PATCH 8/8] VSMS: add default console

[John Ferlan]

On 09/05/2013 11:36 AM, Viktor Mihajlovski wrote:
> From: Thilo Boehm <tboehm at linux.vnet.ibm.com>
> 
> A new function to add a default console has been added. As with
> the default graphics and default input device, the default device
> generation is optional and depends on the domain type and
> architecture.
> Initially, we only create an s390 console, which is necessary to
> define a runnable guest.
> 
> Signed-off-by: Thilo Boehm <tboehm at linux.vnet.ibm.com>
> Signed-off-by: Viktor Mihajlovski <mihajlov at linux.vnet.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
> ---
>  src/Virt_VirtualSystemManagementService.c |   34 +++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
ACK

John

FYI: The not checking for memory allocation is endemic throughout
libvirt-cim.  I suppose "some day" it would be good to do something
about it, but there's so many assumptions now it'd probably take the
libvirt VIR_ALLOC, VIR_STRDUP, etc macros to fix all the instances.