[Libvirt-cim] [PATCH 0/3] cimtest: Changes for live.full_hostname

John Ferlan jferlan at redhat.com
Mon Jun 16 10:30:45 UTC 2014



On 05/20/2014 02:26 PM, John Ferlan wrote:
> Series of patches to close the loop on prior set of cimtest changes:
> 
> http://www.redhat.com/archives/libvirt-cim/2014-April/msg00002.html
> 
> Based primarily on feedback/investigation done as part of a prior
> cimtest commit:
> 
> http://www.redhat.com/archives/libvirt-cim/2014-May/msg00012.html
> 
> Patch 1 of 3 modifies the full_hostname() call to use getfqdn() only. A
> prior patch would attempt the gethostname() if something failed, but as
> seen through the documentation of the in the above link - thats also a
> fallback for getfqdn().  
> 
> Patches 2&3 remove the check_sblim() usage.  See the commit messages for
> details.
> 
> John Ferlan (3):
>   live.full_hostname: Adjust mechanism to get FQDN
>   HostSystem: Remove call to check_sblim
>   XenKvmLib: Remove check_sblim()
> 
>  lib/VirtLib/live.py                                |  6 +--
>  .../cimtest/ElementConforms/04_ectp_rev_errs.py    |  2 +-
>  suites/libvirt-cim/cimtest/HostSystem/01_enum.py   | 56 +++++++---------------
>  .../cimtest/HostSystem/03_hs_to_settdefcap.py      |  2 +-
>  suites/libvirt-cim/lib/XenKvmLib/common_util.py    | 28 -----------
>  suites/libvirt-cim/lib/XenKvmLib/vxml.py           |  2 +-
>  6 files changed, 24 insertions(+), 72 deletions(-)
> 

Any thoughts/comments on patches 2 & 3 to remove check_sblim()?

Tks,

John




More information about the Libvirt-cim mailing list