[libvirt-users] glib2 head file error when build libvirt with wireshark support

[Michal Privoznik]

On 16.02.2016 18:47, Daniel P. Berrange wrote:
> On Mon, Feb 15, 2016 at 10:40:11AM +0100, Martin Kletzander wrote:
>> On Mon, Feb 15, 2016 at 03:05:00AM -0500, Han Han wrote:
>>> I compile the latest libvirt from fedora rawhide, but failed.
>>> The version of my software:
>>> wireshark-devel-2.0.1-2.fc24.x86_64
>>> glib2-2.47.5-2.fc24.x86_64
>>> gcc-5.1.1-4.fc23.x86_64
>>> binutils-2.26-10.fc24.x86_64
>>>
>>
>> Can you post the output of:
>>
>>  pkg-config --print-requires wireshark
>>
>> If it does not output glib-2.0 and gmodule-2.0, then it's your wireshark
>> broken.  I see they have it fixed upstream (thanks to Michal, BTW), so
>> the next release should be fine.  In the meantime, you can just edit
>> your /usr/lib/pkgconfig/wireshark.pc to have the following line in it:
>>
>>  Requires: glib-2.0, gmodule-2.0, gthread-2.0
> 
> Where do you see it fixed upstream ? The pkg-config file is patched
> in locally by Fedora RPM spec file and it was the Fedora wireshark
> maintainer who broke it AFAICT
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1300002
> 

I guess Martin was referring to my wireshark upstream commit:

commit ea16a84ef51b0e50a40789adcfbe71b6f3c60ed1
Author:     Michal Privoznik <miso.privoznik at gmail.com>
AuthorDate: Sat Dec 26 17:13:00 2015 +0100
Commit:     Anders Broman <a.broman58 at gmail.com>
CommitDate: Mon Jan 4 08:15:29 2016 +0000

    Generate better pkg-config file

    Firstly, when building with autogen.sh and configure script, the
    wireshark.pc is not generated at all. Then, due to not matching
    names some variables are not being replaced as they should be.

    Bug: 11069
    Change-Id: Iefa7a9b536f3fee7f9ad78803aaacc5bb64a9c8d
    Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
    Reviewed-on: https://code.wireshark.org/review/13005
    Reviewed-by: João Valverde <j at v6e.pt>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org>
    Reviewed-by: Anders Broman <a.broman58 at gmail.com>

https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea16a84ef51b0e50a40789adcfbe71b6f3c60ed1

Yes, fedora's broken because it used to generate it's own pkg-config
file as those before my patch were unusable. The commit still waits for
next wireshark release though.

Michal