Escape character

[Daniel P. Berrangé]

On Fri, Mar 27, 2020 at 03:27:56PM +0100, Ján Tomko wrote:
> On a Friday in 2020, Erik Skultety wrote:
> > On Fri, Mar 27, 2020 at 01:48:58PM +0000, Daniel P. Berrangé wrote:
> > > On Fri, Mar 27, 2020 at 01:45:21PM +0100, Ján Tomko wrote:
> > > > On a Friday in 2020, john doe wrote:
> > > > > Hi,
> > > > >
> > > > > I'm trying to understand how to use the escape character '^]' with the
> > > > > below command:
> > > > >
> > > > > virt-install --name=try06 --graphic none --pxe --network bridge=virbr0
> > > > > --console pty,target_type=serial
> > > > >
> > > > > "Starting install...
> > > > > Connected to domain try06
> > > > > Escape character is ^]"
> > > > >
> > > > > When I try to do '^]', it does not escape.
> > > > >
> > > >
> > > > This is not a character sequence, '^]' is a way of saying: Ctrl + ]
> > > 
> > > Stop me if i'm being too adventurous here, but perhaps we should
> > > change the text to say....
> 
> My short adventure to virsh source code lead me to find out that the
> escape character is configurable, so it's more than just changing a
> text.

Oh yes, I forgot we did that.

> 
> > > 
> > >  Escape character is Ctrl + ]
> > 
> > Well, as we can clearly see, not everyone is familiar with the caret notation.
> 
> We could teach the caret notation (at the expense of minimalism):
> Escape character is ^] (Ctrl + ])
> 
> > So, I definitely support such a change.
> 
> The best way to show your support is by sending a patch ;)

I'll have a go at writing a patch

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|