audit_log_drain

Chris Wright chrisw at osdl.org
Thu Apr 7 00:09:59 UTC 2005


* David Woodhouse (dwmw2 at infradead.org) wrote:
> Hunk #1 FAILED at 143.
> patch: **** malformed patch at line 91: {                        skb_queue_tail(&ab->sklist, skb);
> 
> On the offending line, why skb_queue_tail() -- shouldn't this queue back
> at the _head_ of the queue?
> 
> (I know it was already like that before you touched it, Steve, but I
> still don't think it's _right_).

Actually, I agree.  What's the point?  We should requeue the skb that we
choked on at the head to help guarantee that it's (as close as possible
to) the first retransmitted.

thanks,
-chris




More information about the Linux-audit mailing list