[RFC][PATCH 1/3] (#7) updated file system auditing patches

David Woodhouse dwmw2 at infradead.org
Wed Apr 20 02:55:33 UTC 2005


On Sat, 2005-04-16 at 05:07 +0000, Timothy R. Chavez wrote:
> --- linux-2.6.9~orig/include/linux/fs.h 2005-04-13 20:38:29.000000000
> +0000
> +++ linux-2.6.9~audit/include/linux/fs.h        2005-04-13
> 20:07:25.000000000 +0000
> @@ -220,6 +220,7 @@ extern int leases_enable, dir_notify_ena
>  #include <linux/list.h>
>  #include <linux/radix-tree.h>
>  #include <linux/init.h>
> +include  <linux/audit.h>
>  #include <asm/semaphore.h>
>  #include <asm/byteorder.h>

Even without the typo we don't want that. We don't want to have to
rebuild everything that includes fs.h, every time we touch audit.h.
Neither do we want to break the evil code in x86_64 binfmt_ia32.c which
depends on being able to override certain ELF stuff before including
elf.h.

Just add a forward declaration of struct audit_data instead...

--- linux-2.69/include/linux/fs.h.auditfs2      2005-04-06 13:12:57.000000000 +0100
+++ linux-2.69/include/linux/fs.h       2005-04-06 13:45:56.000000000 +0100
@@ -27,6 +27,7 @@ struct poll_table_struct;
 struct kstatfs;
 struct vm_area_struct;
 struct vfsmount;
+struct audit_data;

 /*
  * It's silly to have NR_OPEN bigger than NR_FILE, but you can change


-- 
dwmw2




More information about the Linux-audit mailing list