[PATCH] Small kfree cleanup, save a local variable.
Chris Wright
chrisw at osdl.org
Sun Jun 19 20:13:54 UTC 2005
* Jesper Juhl (juhl-lkml at dif.dk) wrote:
> Here's a patch with a small improvement to kernel/auditsc.c .
> There's no need for the local variable struct audit_entry *e ,
> we can just call kfree directly on container_of() .
> Patch also removes an extra space a little further down in the file.
Please Cc: linux-audit at redhat.com on audit patches. I tend to agree
with Michael, it's optimized away, and readable as is.
thanks,
-chris
> Signed-off-by: Jesper Juhl <juhl-lkml at dif.dk>
> ---
>
> kernel/auditsc.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> --- linux-2.6.12-orig/kernel/auditsc.c 2005-06-17 21:48:29.000000000 +0200
> +++ linux-2.6.12/kernel/auditsc.c 2005-06-19 21:21:37.000000000 +0200
> @@ -202,8 +202,7 @@ static inline int audit_add_rule(struct
>
> static void audit_free_rule(struct rcu_head *head)
> {
> - struct audit_entry *e = container_of(head, struct audit_entry, rcu);
> - kfree(e);
> + kfree(container_of(head, struct audit_entry, rcu));
> }
>
> /* Note that audit_add_rule and audit_del_rule are called via
> @@ -612,7 +611,7 @@ static inline void audit_free_context(st
> audit_free_names(context);
> audit_free_aux(context);
> kfree(context);
> - context = previous;
> + context = previous;
> } while (context);
> if (count >= 10)
> printk(KERN_ERR "audit: freed %d contexts\n", count);
More information about the Linux-audit
mailing list