[RFC][PATCH] (#6 U1) the latest incarnation

Timothy R. Chavez tinytim at us.ibm.com
Thu Mar 24 16:36:27 UTC 2005


On Thursday 24 March 2005 10:19 am, Stephen Smalley wrote:
> On Thu, 2005-03-24 at 10:03 -0600, Timothy R. Chavez wrote:
> > No testing on SMP as of right now, I'll get right on this right now.
>
> In audit_attach_watch(), you call audit_wentry_fetch_lock() which takes
> read lock of the parent while holding the write lock on the entry.  What
> if dentry->d_parent == dentry, i.e. root inode of a filesystem?

Funny you mentioned this.  Right after you told me about the deadlock you were 
getting, I went and looked at this function, and noticed the same thing.  I'm 
now testing for this case.

-- 
-tim




More information about the Linux-audit mailing list