Log corruption

Steve Grubb sgrubb at redhat.com
Tue May 10 18:14:40 UTC 2005


On Tuesday 10 May 2005 13:30, David Woodhouse wrote:
> +               avail = audit_expand(ab, 1+len-avail);

Just 2 comments, don't you want to acquire a little extra memory rather than 
just meeting the needs? About half the time one vformat is followed by 
another. I was thinking that it would have been rounded up to the next 
AUDIT_BUFSIZ multiple.

The other comment is int? (int extra) sb unsigned?

Neither of these comments are showstoppers...it works fine as is.

-Steve




More information about the Linux-audit mailing list