moving audit_free() up into do_exit()

Steve Grubb sgrubb at redhat.com
Fri Mar 31 20:40:30 UTC 2006


On Thursday 30 March 2006 03:56, Alexander Viro wrote:
> On Thu, Mar 30, 2006 at 03:54:53AM -0500, Alexander Viro wrote:
> > OK, preliminary patches attached; the first one is minimal "take care of
>
> Gah...  Attached to this followup; my apologies.

In audit-exit.patch

@@ -607,12 +605,12 @@ static void audit_log_exit(struct audit_
 		  context->gid,
 		  context->euid, context->suid, context->fsuid,
 		  context->egid, context->sgid, context->fsgid, tty);
-	audit_log_task_info(ab, gfp_mask);
+	audit_log_task_info(ab);
 	audit_log_end(ab);
 
 	for (aux = context->aux; aux; aux = aux->next) {
 
-		ab = audit_log_start(context, gfp_mask, aux->type);
+		ab = audit_log_start(context, GFP_KERNEL, aux->type);
 		if (!ab)
 			continue; /* audit_panic has been called */
 
It doesn't compile....it needs:
+	audit_log_task_info(ab, tsk);


Also, piece in kernel/exit.c complains of implicit declaration of 
'audit_free'.

-Steve




More information about the Linux-audit mailing list