the format string of printf to print audit status is wrong

Yu Zhiguo yuzg at cn.fujitsu.com
Fri Aug 1 09:21:35 UTC 2008


Hello Eric,
CC Steve,

Eric Paris wrote:
> So it seems reasonable to switch backlog=%d to backlog=%u but all of the
> other values "could" be negative and should be shown as ints.
> 

 Thanks for your kindness remind.
 I also think all of the other values "could" be negative and should
be shown as ints.

 A new patch for auditctl:

---
 src/auditctl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/auditctl.c b/src/auditctl.c
index d740509..44ca038 100644
--- a/src/auditctl.c
+++ b/src/auditctl.c
@@ -1350,7 +1350,7 @@ static int audit_print_reply(struct audit_reply *rep)
 			return 0;
 		case AUDIT_GET:
 			printf("AUDIT_STATUS: enabled=%d flag=%d pid=%d"
-			" rate_limit=%d backlog_limit=%d lost=%d backlog=%d\n",
+			" rate_limit=%d backlog_limit=%d lost=%d backlog=%u\n",
 			rep->status->enabled, rep->status->failure,
 			rep->status->pid, rep->status->rate_limit,
 			rep->status->backlog_limit, rep->status->lost,




More information about the Linux-audit mailing list