[PATCH 7/15] sanitize AUDIT_MQ_SENDRECV

James Morris jmorris at namei.org
Wed Dec 17 07:40:54 UTC 2008


On Wed, 17 Dec 2008, Al Viro wrote:

> 
> * logging the original value of *msg_prio in mq_timedreceive(2)
>   is insane - the argument is write-only (i.e. syscall always
>   ignores the original value and only overwrites it).

I wonder if any existing certifications need to be amended.

> * merge __audit_mq_timed{send,receive}
> * don't do copy_from_user() twice
> * don't mess with allocations in auditsc part
> * ... and don't bother checking !audit_enabled and !context in there -
>   we'd already checked for audit_dummy_context().
> 
> Signed-off-by: Al Viro <viro at zeniv.linux.org.uk>


Reviewed-by: James Morris <jmorris at namei.org>

-- 
James Morris
<jmorris at namei.org>




More information about the Linux-audit mailing list