PATCH [1/1]: audit: acquire creds selectively to reduce atomic op overhead

David Howells dhowells at redhat.com
Tue Mar 15 20:04:47 UTC 2011


Tony Jones <tonyj at suse.de> wrote:

> Agree. Also I believe it is safe to use tsk->cred directly as tsk == current 
> or tsk is being created by copy_process.  

You can't quite access it like that without sparse throwing a warning.  The
pointer is marked with an __rcu attribute, so you need to use something like
this:

	cred = rcu_dereference_check(tsk->cred, (tsk == current ||
						 called_from_copy_process());

David




More information about the Linux-audit mailing list