[PATCH 1/3] audit: fix incorrect order of log new and old feature

[Richard Guy Briggs]

On Thu, Oct 31, 2013 at 04:27:56PM +0800, Gao feng wrote:
> Signed-off-by: Gao feng <gaofeng at cn.fujitsu.com>

Gao,

Could you provide some description, justification and references for
each of the patches in this patchset please?

> ---
>  kernel/audit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 7c7c028..f16f835 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -664,7 +664,7 @@ static void audit_log_feature_change(int which, u32 old_feature, u32 new_feature
>  	struct audit_buffer *ab;
>  
>  	ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_FEATURE_CHANGE);
> -	audit_log_format(ab, "feature=%s new=%d old=%d old_lock=%d new_lock=%d res=%d",
> +	audit_log_format(ab, "feature=%s old=%d new=%d old_lock=%d new_lock=%d res=%d",
>  			 audit_feature_names[which], !!old_feature, !!new_feature,
>  			 !!old_lock, !!new_lock, res);
>  	audit_log_end(ab);
> -- 
> 1.8.3.1
> 

- RGB

--
Richard Guy Briggs <rbriggs at redhat.com>
Senior Software Engineer
Kernel Security
AMER ENG Base Operating Systems
Remote, Ottawa, Canada
Voice: +1.647.777.2635
Internal: (81) 32635
Alt: +1.613.693.0684x3545