[PATCH 7/8] audit: clean up AUDIT_GET/SET local variables and future-proof API
Richard Guy Briggs
rgb at redhat.com
Mon Sep 23 16:38:28 UTC 2013
On Fri, Sep 20, 2013 at 10:47:50AM -0400, Eric Paris wrote:
> On Thu, 2013-09-19 at 17:18 -0400, Steve Grubb wrote:
> > On Wednesday, September 18, 2013 03:06:52 PM Richard Guy Briggs wrote:
> > > Re-named confusing local variable names (status_set and status_get didn't
> > > agree with their command type name) and reduced their scope.
> > >
> > > Future-proof API changes by not depending on the exact size of the
> > > audit_status struct.
> > Also, because there is no way to query the kernel to see what kind of things
> > it supports
>
> I'll agree. Richard, can you please add a version field to the status?
> Start at version 1. Any time we add a new audit feature we'll bump it.
Done. Adding the interface and version field is version 1, so without,
it is zero. Adding the backlog timeout is version 2.
- RGB
--
Richard Guy Briggs <rbriggs at redhat.com>
Senior Software Engineer
Kernel Security
AMER ENG Base Operating Systems
Remote, Ottawa, Canada
Voice: +1.647.777.2635
Internal: (81) 32635
Alt: +1.613.693.0684x3545
More information about the Linux-audit
mailing list