[PATCH 2/2] audit: reorder AUDIT_TTY_SET arguments

Eric Paris eparis at redhat.com
Tue Jan 14 02:18:10 UTC 2014


An admin is likely to want to see old and new values next to each other.
Putting all of the old values followed by all of the new values is just
hard to read as a human.

Signed-off-by: Eric Paris <eparis at redhat.com>
---
 kernel/audit.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 5f7d2d9..d9b4b43 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1018,13 +1018,10 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
 		spin_unlock(&tsk->sighand->siglock);
 
 		audit_log_common_recv_msg(&ab, AUDIT_CONFIG_CHANGE);
-		audit_log_format(ab, " op=tty_set"
-				 " old-enabled=%d old-log_passwd=%d"
-				 " new-enabled=%d new-log_passwd=%d"
-				 " res=%d",
-				 old.enabled, old.log_passwd,
-				 s.enabled, s.log_passwd,
-				 !err);
+		audit_log_format(ab, " op=tty_set old-enabled=%d new-enabled=%d"
+				 " old-log_passwd=%d new-log_passwd=%d res=%d",
+				 old.enabled, s.enabled, old.log_passwd,
+				 s.log_passwd, !err);
 		audit_log_end(ab);
 		break;
 	}
-- 
1.8.4.2




More information about the Linux-audit mailing list