[PATCH 03/15] tty: audit: Remove icanon mode from call chain

[Richard Guy Briggs]

On 15/11/12, Peter Hurley wrote:
> On 11/12/2015 02:10 PM, Richard Guy Briggs wrote:
> > On 15/11/10, Peter Hurley wrote:
> >> The tty termios bits cannot change while n_tty_read() is in the
> >> i/o loop; the termios_rwsem ensures mutual exclusion with termios
> >> changes in n_tty_set_termios(). Check L_ICANON() directly and
> >> eliminate icanon parameter.
> >>
> >> NB: tty_audit_add_data() => tty_audit_buf_get() => tty_audit_buf_alloc()
> >> is a single path; ie., tty_audit_buf_get() and tty_audit_buf_alloc()
> >> have no other callers.
> > 
> > Which tree is this based on?  I don't see where the first chunk applies.
> 
> 4.3
> 
> but this series requires a -stable fix [1] posted earlier but not in any
> tree yet, which I noted in the cover-letter (was easy to overlook).

Ok, found it.  It appears to also depend on "n_tty: Uninline
tty_copy_to_user()" [2] which I didn't see mentioned and can't find
upstream.  Is that in an upstream tree?

> Regards,
> Peter Hurley
> 
> [1] https://lkml.org/lkml/2015/11/8/133

[2] https://lkml.org/lkml/2015/11/8/146

- RGB

--
Richard Guy Briggs <rbriggs at redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545