[PATCH] errormsg: use descriptive macros for error numbers

Steve Grubb sgrubb at redhat.com
Tue Apr 11 21:33:08 UTC 2017


On Tuesday, April 4, 2017 6:36:52 AM EDT Richard Guy Briggs wrote:
> Convert all the numerical error return codes in comparison option and field
> option parsing routines audit_rule_interfield_comp_data() and
> audit_rule_fieldpair_data() to descriptive macros for easier code navigation
> and verification.
> 
> See: https://github.com/linux-audit/audit-userspace/issues/11
> 
> Signed-off-by: Richard Guy Briggs <rgb at redhat.com>
> ---
>  lib/errormsg.h |   29 +++++++++++++++++++
>  lib/libaudit.c |   84
> ++++++++++++++++++++++++++++---------------------------- 2 files changed,
> 71 insertions(+), 42 deletions(-)

Applied. But we still have hardcoded numbers in the err_msgtab[].  :-)

Thanks,
-Steve




More information about the Linux-audit mailing list