[PATCH] audit: remove unnecessary curly braces from switch/case statements

Richard Guy Briggs rgb at redhat.com
Mon Feb 13 21:43:01 UTC 2017


On 2017-02-13 16:25, Paul Moore wrote:
> From: Paul Moore <paul at paul-moore.com>
> 
> Signed-off-by: Paul Moore <paul at paul-moore.com>

Reviewed-by: Richard Guy Briggs <rgb at redhat.com>

> ---
>  kernel/auditsc.c |   24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index bde3aac4deed..4db32e8669f8 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1221,7 +1221,7 @@ static void show_special(struct audit_context *context, int *call_panic)
>  				context->ipc.perm_mode);
>  		}
>  		break; }
> -	case AUDIT_MQ_OPEN: {
> +	case AUDIT_MQ_OPEN:
>  		audit_log_format(ab,
>  			"oflag=0x%x mode=%#ho mq_flags=0x%lx mq_maxmsg=%ld "
>  			"mq_msgsize=%ld mq_curmsgs=%ld",
> @@ -1230,8 +1230,8 @@ static void show_special(struct audit_context *context, int *call_panic)
>  			context->mq_open.attr.mq_maxmsg,
>  			context->mq_open.attr.mq_msgsize,
>  			context->mq_open.attr.mq_curmsgs);
> -		break; }
> -	case AUDIT_MQ_SENDRECV: {
> +		break;
> +	case AUDIT_MQ_SENDRECV:
>  		audit_log_format(ab,
>  			"mqdes=%d msg_len=%zd msg_prio=%u "
>  			"abs_timeout_sec=%ld abs_timeout_nsec=%ld",
> @@ -1240,12 +1240,12 @@ static void show_special(struct audit_context *context, int *call_panic)
>  			context->mq_sendrecv.msg_prio,
>  			context->mq_sendrecv.abs_timeout.tv_sec,
>  			context->mq_sendrecv.abs_timeout.tv_nsec);
> -		break; }
> -	case AUDIT_MQ_NOTIFY: {
> +		break;
> +	case AUDIT_MQ_NOTIFY:
>  		audit_log_format(ab, "mqdes=%d sigev_signo=%d",
>  				context->mq_notify.mqdes,
>  				context->mq_notify.sigev_signo);
> -		break; }
> +		break;
>  	case AUDIT_MQ_GETSETATTR: {
>  		struct mq_attr *attr = &context->mq_getsetattr.mqstat;
>  		audit_log_format(ab,
> @@ -1255,19 +1255,19 @@ static void show_special(struct audit_context *context, int *call_panic)
>  			attr->mq_flags, attr->mq_maxmsg,
>  			attr->mq_msgsize, attr->mq_curmsgs);
>  		break; }
> -	case AUDIT_CAPSET: {
> +	case AUDIT_CAPSET:
>  		audit_log_format(ab, "pid=%d", context->capset.pid);
>  		audit_log_cap(ab, "cap_pi", &context->capset.cap.inheritable);
>  		audit_log_cap(ab, "cap_pp", &context->capset.cap.permitted);
>  		audit_log_cap(ab, "cap_pe", &context->capset.cap.effective);
> -		break; }
> -	case AUDIT_MMAP: {
> +		break;
> +	case AUDIT_MMAP:
>  		audit_log_format(ab, "fd=%d flags=0x%x", context->mmap.fd,
>  				 context->mmap.flags);
> -		break; }
> -	case AUDIT_EXECVE: {
> +		break;
> +	case AUDIT_EXECVE:
>  		audit_log_execve_info(context, &ab);
> -		break; }
> +		break;
>  	case AUDIT_KERN_MODULE:
>  		audit_log_format(ab, "name=");
>  		audit_log_untrustedstring(ab, context->module.name);
> 
> --
> Linux-audit mailing list
> Linux-audit at redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit

- RGB

--
Richard Guy Briggs <rgb at redhat.com>
Kernel Security Engineering, Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635




More information about the Linux-audit mailing list