[PATCH 1/2] errormsg: correct a number of messages that have drifted
Richard Guy Briggs
rgb at redhat.com
Thu May 4 20:25:04 UTC 2017
On 2017-05-04 15:50, Steve Grubb wrote:
> On Tuesday, April 4, 2017 6:37:47 AM EDT Richard Guy Briggs wrote:
> > A number of error message descriptions have drifted from the conditions that
> > caused them in audit_rule_fieldpair_data() including expansion of fields to
> > be used by the user filter list, restriction to the exit list only and
> > changing an operator to "equals" only. Correct these, using the new
> > errormsg macros.
> >
> > See: https://github.com/linux-audit/audit-userspace/issues/12
> >
> > Signed-off-by: Richard Guy Briggs <rgb at redhat.com>
>
> This was hard to check because the first patch switch numbers to macros in
> libaudit.c, but did not change them in the errormsg tab. It would have been
> better to apply this first and then change to macros or change everything to
> macros and then do this last. In any event, it's applied.
Thanks Steve. I didn't discover the need for this until after I had
done the macro conversion, hence the order of the patches. I could have
re-ordered the patches to make them easier to check.
> -Steve
- RGB
--
Richard Guy Briggs <rgb at redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
More information about the Linux-audit
mailing list